Bug 77774 - [chromium] Compositor: multi-second hangs invalidating large layers
Summary: [chromium] Compositor: multi-second hangs invalidating large layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 13:47 PST by Stephen White
Modified: 2012-02-04 01:26 PST (History)
5 users (show)

See Also:


Attachments
Test case (755 bytes, text/html)
2012-02-03 13:47 PST, Stephen White
no flags Details
Patch (2.10 KB, patch)
2012-02-03 13:57 PST, Stephen White
no flags Details | Formatted Diff | Diff
Patch (3.46 KB, patch)
2012-02-03 14:47 PST, Stephen White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2012-02-03 13:47:28 PST
Created attachment 125405 [details]
Test case

When invalidating large layers, the compositor pauses for several seconds at a time.  The attached file takes several seconds to load with the compositor on.  It is virtually instant with the compositor off.

See also http://code.google.com/p/chromium/issues/detail?id=111663.
Comment 1 Stephen White 2012-02-03 13:57:15 PST
Created attachment 125409 [details]
Patch
Comment 2 Stephen White 2012-02-03 14:47:43 PST
Created attachment 125421 [details]
Patch
Comment 3 Stephen White 2012-02-03 15:01:02 PST
(In reply to comment #2)
> Created an attachment (id=125421) [details]
> Patch

This version, in addition to invalidating tiles by iterating over the hash map rather than the tile indices, removes invalid tiles (those without texture backing) in TiledLayerChromium::pushPropertiesTo(), which limits the number of tiles by the size of the texture cache.
Comment 4 Adrienne Walker 2012-02-03 16:04:17 PST
Comment on attachment 125421 [details]
Patch

Unofficially LGTM.  Thanks for this!
Comment 5 James Robinson 2012-02-03 16:10:37 PST
Comment on attachment 125421 [details]
Patch

R=me
Comment 6 WebKit Review Bot 2012-02-04 01:26:32 PST
Comment on attachment 125421 [details]
Patch

Clearing flags on attachment: 125421

Committed r106732: <http://trac.webkit.org/changeset/106732>
Comment 7 WebKit Review Bot 2012-02-04 01:26:36 PST
All reviewed patches have been landed.  Closing bug.