positive and negative flex values are not being cleared on style changes
Created attachment 125397 [details] Patch
Comment on attachment 125397 [details] Patch How about writing this as: float positiveFlex = 0; float negativeFlex = 0; if (!value->isPrimitiveValue()) { if (!flexDirection || !value->isFlexValue()) return; CSSFlexValue* flexValue = static_cast<CSSFlexValue*>(value); value = flexValue->preferredSize(); positiveFlex = flexValue->positiveFlex(); negativeFlex = flexValue->negativeFlex(); } if (flexDirection == FlexWidth) { ... } else if (flexDirection == FlexHeight) { ... }
Created attachment 125402 [details] Patch for landing
Comment on attachment 125402 [details] Patch for landing Clearing flags on attachment: 125402 Committed r106704: <http://trac.webkit.org/changeset/106704>
All reviewed patches have been landed. Closing bug.