Bug 77770 - [chromium] Use explicit casts for WebRect/WebSize to IntRect/IntSize conversions
Summary: [chromium] Use explicit casts for WebRect/WebSize to IntRect/IntSize conversions
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 71143
  Show dependency tree / graph
 
Reported: 2012-02-03 13:17 PST by Emil A Eklund
Modified: 2012-02-08 13:32 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.32 KB, patch)
2012-02-03 13:33 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-02-03 13:17:09 PST 
With the introduction of FixedRect/Size/Point the implicit conversion path from WebRect to IntRect is no longer unambiguous.
Comment 1 Emil A Eklund 2012-02-03 13:33:56 PST 
Created attachment 125399 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-03 14:03:08 PST 
Comment on attachment 125399 [details]
Patch

I'm not sure what this buys us.  It's nice that these implicitly convert.  What benifit of removed ambiguity is there?  Or was this just helpful to you while writing your layout patch (as I assume you may have removed the implicit constructors to find all the callsites and check them?)
Comment 3 Emil A Eklund 2012-02-03 14:04:59 PST 
It avoids "ambiguous conversion" compiler errors when building with the sub pixel units on certain platforms, most notably windows.
Comment 4 Eric Seidel (no email) 2012-02-03 14:08:44 PST 
I see.  Could you tell me which conversions it thinks are ambigious?  As in could you paste either an example warning (or a made up one?)  Just so I understand what I'd be approving here.  :)
Comment 5 Eric Seidel (no email) 2012-02-03 14:09:25 PST 
Given that thsi is chromium only, I probably should remove the various apple folks I CC'd.  Sorry for the bug spam.
Comment 6 Emil A Eklund 2012-02-03 14:32:36 PST 
> I see.  Could you tell me which conversions it thinks are ambigious?  As in could you paste either an example warning (or a made up one?)

Of course, I'll kick off a build without these changes right away and report back.
Comment 7 Emil A Eklund 2012-02-08 13:32:33 PST 
As we no longer have implicit conversion between FixedRect/Point/Size and platform specific types this patch is now obsolete.