Bug 77770 – [chromium] Use explicit casts for WebRect/WebSize to IntRect/IntSize conversions

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit Misc.

[Emil A Eklund]

With the introduction of FixedRect/Size/Point the implicit conversion path from WebRect to IntRect is no longer unambiguous.

[Emil A Eklund]

Created attachment 125399 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 125399 [details]
Patch

I'm not sure what this buys us.  It's nice that these implicitly convert.  What benifit of removed ambiguity is there?  Or was this just helpful to you while writing your layout patch (as I assume you may have removed the implicit constructors to find all the callsites and check them?)

[Emil A Eklund]

It avoids "ambiguous conversion" compiler errors when building with the sub pixel units on certain platforms, most notably windows.

[Eric Seidel (no email)]

I see.  Could you tell me which conversions it thinks are ambigious?  As in could you paste either an example warning (or a made up one?)  Just so I understand what I'd be approving here.  :)

[Eric Seidel (no email)]

Given that thsi is chromium only, I probably should remove the various apple folks I CC'd.  Sorry for the bug spam.

[Emil A Eklund]

> I see.  Could you tell me which conversions it thinks are ambigious?  As in could you paste either an example warning (or a made up one?)

Of course, I'll kick off a build without these changes right away and report back.

[Emil A Eklund]

As we no longer have implicit conversion between FixedRect/Point/Size and platform specific types this patch is now obsolete.