Bug 77765 - Add a Mac Lion Performance bot
Summary: Add a Mac Lion Performance bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency tree / graph
 
Reported: 2012-02-03 12:55 PST by Lucas Forschler
Modified: 2012-02-03 16:01 PST (History)
2 users (show)

See Also:

Attachments
patch for review (4.52 KB, patch)
2012-02-03 13:02 PST, Lucas Forschler 		aroben: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
updated patch. (4.52 KB, patch)
2012-02-03 13:35 PST, Lucas Forschler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2012-02-03 12:55:15 PST 
Chromium has a performance bot, mirror one for Mac Lion.
Comment 1 Lucas Forschler 2012-02-03 13:02:49 PST 
Created attachment 125390 [details]
patch for review
Comment 2 Ryosuke Niwa 2012-02-03 13:13:28 PST 
Great! Thanks for adding a bot.
Comment 3 WebKit Review Bot 2012-02-03 13:27:14 PST 
Comment on attachment 125390 [details]
patch for review

Rejecting attachment 125390 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11424356
Comment 4 Ryosuke Niwa 2012-02-03 13:28:38 PST 
Comment on attachment 125390 [details]
patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=125390&action=review

> Tools/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=77765

Bug url should appear immediately below the bug summary "Add a Mac Lion Performance bot."
After that, one blank line and there should be "Reviewed by X" line.
Comment 5 Lucas Forschler 2012-02-03 13:35:07 PST 
Created attachment 125400 [details]
updated patch.

The previous patch had the bug link in the wrong place.  This should fix it.
Comment 6 WebKit Review Bot 2012-02-03 16:01:27 PST 
Comment on attachment 125400 [details]
updated patch.

Clearing flags on attachment: 125400

Committed r106703: <http://trac.webkit.org/changeset/106703>
Comment 7 WebKit Review Bot 2012-02-03 16:01:32 PST 
All reviewed patches have been landed.  Closing bug.