RESOLVED FIXED Bug 77762
ScrollingTreeState should keep track of the scroll layer 
https://bugs.webkit.org/show_bug.cgi?id=77762
Summary ScrollingTreeState should keep track of the scroll layer
Anders Carlsson
Reported 2012-02-03 12:15:45 PST
ScrollingTreeState should keep track of the scroll layer
Attachments
Patch (7.96 KB, patch)
2012-02-03 12:17 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-02-03 12:17:11 PST
Created attachment 125381 [details] Patch
Darin Adler
Comment 2 2012-02-03 12:20:35 PST
Comment on attachment 125381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125381&action=review > Source/WebCore/ChangeLog:3 > + ScrollingTreeState should keep track of the scroll layer Why? > Source/WebCore/page/scrolling/mac/ScrollingTreeStateMac.mm:36 > +PlatformLayer* ScrollingTreeState::platformScrollLayer() const > +{ > + return m_platformScrollLayer.get(); > +} Inline?
Anders Carlsson
Comment 3 2012-02-03 12:22:35 PST
Committed r106683: <http://trac.webkit.org/changeset/106683>
Anders Carlsson
Comment 4 2012-02-03 14:44:46 PST
(In reply to comment #2) > (From update of attachment 125381 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125381&action=review > > > Source/WebCore/ChangeLog:3 > > + ScrollingTreeState should keep track of the scroll layer > > Why? So it knows what to scroll! :-) > > > Source/WebCore/page/scrolling/mac/ScrollingTreeStateMac.mm:36 > > +PlatformLayer* ScrollingTreeState::platformScrollLayer() const > > +{ > > + return m_platformScrollLayer.get(); > > +} > > Inline? I didn't want to end up with a bunch of different #ifdefs with different inline functions.
Note You need to log in before you can comment on or make changes to this bug.