Bug 77762 - ScrollingTreeState should keep track of the scroll layer
Summary: ScrollingTreeState should keep track of the scroll layer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 12:15 PST by Anders Carlsson
Modified: 2012-02-03 14:44 PST (History)
0 users

See Also:

Attachments
Patch (7.96 KB, patch)
2012-02-03 12:17 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-02-03 12:15:45 PST 
ScrollingTreeState should keep track of the scroll layer
Comment 1 Anders Carlsson 2012-02-03 12:17:11 PST 
Created attachment 125381 [details]
Patch
Comment 2 Darin Adler 2012-02-03 12:20:35 PST 
Comment on attachment 125381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125381&action=review

> Source/WebCore/ChangeLog:3
> +        ScrollingTreeState should keep track of the scroll layer

Why?

> Source/WebCore/page/scrolling/mac/ScrollingTreeStateMac.mm:36
> +PlatformLayer* ScrollingTreeState::platformScrollLayer() const
> +{
> +    return m_platformScrollLayer.get();
> +}

Inline?
Comment 3 Anders Carlsson 2012-02-03 12:22:35 PST 
Committed r106683: <http://trac.webkit.org/changeset/106683>
Comment 4 Anders Carlsson 2012-02-03 14:44:46 PST 
(In reply to comment #2)
> (From update of attachment 125381 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125381&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        ScrollingTreeState should keep track of the scroll layer
> 
> Why?

So it knows what to scroll! :-)

> 
> > Source/WebCore/page/scrolling/mac/ScrollingTreeStateMac.mm:36
> > +PlatformLayer* ScrollingTreeState::platformScrollLayer() const
> > +{
> > +    return m_platformScrollLayer.get();
> > +}
> 
> Inline?

I didn't want to end up with a bunch of different #ifdefs with different inline functions.