Bug 77757 - configure: Two tests are displayed on the same line
Summary: configure: Two tests are displayed on the same line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 11:37 PST by Kalev Lember
Modified: 2012-02-03 13:13 PST (History)
1 user (show)

See Also:


Attachments
configure: Print out the -Wno-c++0x-compat test result (1.95 KB, patch)
2012-02-03 11:39 PST, Kalev Lember
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalev Lember 2012-02-03 11:37:57 PST
The -Wno-c++0x-compat test doesn't print out "yes" or "no" and the following test continues on the same line.

checking if we have to disable C++0x compat warnings for GCC >= 4.6.0... checking pthread.h usability... yes
Comment 1 Kalev Lember 2012-02-03 11:39:59 PST
Created attachment 125373 [details]
configure: Print out the -Wno-c++0x-compat test result

The check whether -Wno-c++0x-compat flag is needed didn't print out
the test result (and newline), which caused the following test to be
displayed on the same line.
Comment 2 Martin Robinson 2012-02-03 12:53:07 PST
Comment on attachment 125373 [details]
configure: Print out the -Wno-c++0x-compat test result

View in context: https://bugs.webkit.org/attachment.cgi?id=125373&action=review

> configure.ac:121
> -CXXFLAGS="$TMPCXXFLAGS", CXXFLAGS="$TMPCXXFLAGS -Wno-c++0x-compat")
> +disable_cxx0x_compat=no,
> +disable_cxx0x_compat=yes)
> +AC_MSG_RESULT($disable_cxx0x_compat)
> +if test "$disable_cxx0x_compat" = yes; then
> +  CXXFLAGS="$TMPCXXFLAGS -Wno-c++0x-compat"
> +else
> +  CXXFLAGS="$TMPCXXFLAGS"
> +fi

Would it be sufficient here to simply add AC_MSG_RESULT
Comment 3 WebKit Review Bot 2012-02-03 13:13:31 PST
Comment on attachment 125373 [details]
configure: Print out the -Wno-c++0x-compat test result

Clearing flags on attachment: 125373

Committed r106688: <http://trac.webkit.org/changeset/106688>
Comment 4 WebKit Review Bot 2012-02-03 13:13:35 PST
All reviewed patches have been landed.  Closing bug.