Bug 77752 - Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
Summary: Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 10:41 PST by Xianzhu Wang
Modified: 2012-02-03 15:53 PST (History)
2 users (show)

See Also:

Attachments
patch (41.17 KB, patch)
2012-02-03 10:43 PST, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
Sorry for uploading patch to wrong bug. Please ignore this. (5.83 KB, text/plain)
2012-02-03 10:49 PST, Xianzhu Wang 		no flags Details
Patch (41.30 KB, patch)
2012-02-03 12:48 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-02-03 10:41:10 PST 
<EOM>
Comment 1 Xianzhu Wang 2012-02-03 10:43:11 PST 
Created attachment 125362 [details]
patch
Comment 2 Xianzhu Wang 2012-02-03 10:49:19 PST 
Created attachment 125364 [details]
Sorry for uploading patch to wrong bug. Please ignore this.

Thanks for suggestions. Not using ASSERT because I don't want the callers to know how viewport update and the main frame are related and to check it.
Comment 3 Dirk Pranke 2012-02-03 12:48:07 PST 
Created attachment 125386 [details]
Patch
Comment 4 Xianzhu Wang 2012-02-03 14:09:58 PST 
(In reply to comment #3)
> Created an attachment (id=125386) [details]
> Patch

Look good to me, but need r+ from some reviewer.
Comment 5 WebKit Review Bot 2012-02-03 15:53:41 PST 
Comment on attachment 125386 [details]
Patch

Clearing flags on attachment: 125386

Committed r106702: <http://trac.webkit.org/changeset/106702>
Comment 6 WebKit Review Bot 2012-02-03 15:53:45 PST 
All reviewed patches have been landed.  Closing bug.