Bug 77746 – [CSSRegions]Implement NamedFlow::getRegionsByContentNode

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mihnea Ovidenie]

Spec: http://dev.w3.org/csswg/css3-regions/#the-namedflow-interface

[Mihnea Ovidenie]

Created attachment 128181 [details]
Patch

[Dave Hyatt]

Comment on attachment 128181 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 128181 [details]
Patch

Rejecting attachment 128181 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
st.h
patching file Source/WebCore/dom/WebKitNamedFlow.cpp
patching file Source/WebCore/dom/WebKitNamedFlow.h
patching file Source/WebCore/dom/WebKitNamedFlow.idl
patching file Source/WebCore/rendering/RenderFlowThread.cpp
patching file Source/WebCore/rendering/RenderFlowThread.h
patching file Source/WebCore/rendering/RenderRegion.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'David Hyatt']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11569139

[Mihnea Ovidenie]

Created attachment 128964 [details]
Patch for landing

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 128964 [details]:

css3/filters/effect-invert-hw.html bug 79639 (author: [e-mail])
inspector/protocol/console-agent.html bug 79563 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 128964 [details]
Patch for landing

Clearing flags on attachment: 128964

Committed r108970: <http://trac.webkit.org/changeset/108970>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Mihnea Ovidenie]

The current implementation, making the returned NodeList a live collection had some issues and was removed from trunk in https://bugs.webkit.org/show_bug.cgi?id=81021.

[Mihnea Ovidenie]

Created attachment 132037 [details]
Patch 3

Implement the list of regions as a static list.

[Ryosuke Niwa]

Comment on attachment 132037 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=132037&action=review

The pathc looks reasonable but I need to either learn how RenderFlowThread works or let someone else review that.

> LayoutTests/fast/regions/get-regions-by-content-node-expected.txt:10
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS
> +PASS

These test results are impossible read. What did pass here?
If you use js-test-pre.js, then you can use assertEqual, etc... to have more meaningful outputs here.

[Mihnea Ovidenie]

Created attachment 132607 [details]
Patch 4

Taking comments into account, simplify tests.

[Dave Hyatt]

Comment on attachment 132607 [details]
Patch 4

r=me

[WebKit Review Bot]

Comment on attachment 132607 [details]
Patch 4

Rejecting attachment 132607 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 126079 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 126079.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11985561

[Eric Seidel (no email)]

Lets try again.  This may be a CQ bug.

[WebKit Review Bot]

Comment on attachment 132607 [details]
Patch 4

Rejecting attachment 132607 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ing file Source/WebCore/dom/WebKitNamedFlow.idl
Hunk #1 FAILED at 32.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/WebKitNamedFlow.idl.rej
patching file Source/WebCore/rendering/RenderFlowThread.cpp
patching file Source/WebCore/rendering/RenderFlowThread.h
patching file Source/WebCore/rendering/RenderRegion.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'David Hyatt']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11984707

[Mihnea Ovidenie]

Created attachment 132774 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 132774 [details]
Patch for landing

Clearing flags on attachment: 132774

Committed r111376: <http://trac.webkit.org/changeset/111376>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.