Bug 77744 – check-webkit-style is throwing an exception

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Philip Rogers]

On a clean checkout, make a minor change to any test_expectation file and then run check-webkit-style. You'll get the following error:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main
    patch_checker.check(patch)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 66, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file
    self._processor.process(lines, file_path, **kwargs)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 826, in process
    checker.check(lines)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 117, in check
    overrides=overrides)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 96, in check_test_expectations
    is_lint_mode=True, overrides=overrides)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 721, in __init__
    self._add_skipped_tests(port.skipped_tests(tests))
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 376, in skipped_tests
    return self.skipped_layout_tests(test_list)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 372, in skipped_layout_tests
    tests_to_skip.update(self._skipped_tests_for_unsupported_features(test_list))
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 319, in _skipped_tests_for_unsupported_features
    if self._has_test_in_directories(self._missing_feature_to_skipped_tests().values(), test_list):
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 311, in _has_test_in_directories
    for directory, test in itertools.product(directories, test_list):
TypeError: 'NoneType' object is not iterable

This same output can be seen on various bugs, for instance:
https://bugs.webkit.org/show_bug.cgi?id=77067
https://bugs.webkit.org/show_bug.cgi?id=77245

[Eric Seidel (no email)]

Sounds like this is a regression from yesterday?

[Eric Seidel (no email)]

Likely from Ojan's changes to speed up NRWT.

[Ojan Vafai]

Created attachment 125437 [details]
Patch

[David Levin]

Comment on attachment 125437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125437&action=review

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:313
>          directories = itertools.chain.from_iterable(directory_lists)

Would it make sense to make itertools.product return [] in this case, so every place that uses it just works when "not test_list"?

[Ojan Vafai]

(In reply to comment #4)
> (From update of attachment 125437 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125437&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:313
> >          directories = itertools.chain.from_iterable(directory_lists)
> 
> Would it make sense to make itertools.product return [] in this case, so every place that uses it just works when "not test_list"?

It might, but it's a python library, so... :)

[WebKit Review Bot]

Comment on attachment 125437 [details]
Patch

Clearing flags on attachment: 125437

Committed r106735: <http://trac.webkit.org/changeset/106735>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.