Bug 77737 – REGRESSION (r103851): Placeholder text is offset too low on ancestry.com home page

• Status: RESOLVED
• Resolution: FIXED
• Component: Evangelism

[David Kilzer (:ddkilzer)]

* SUMMARY
The "First" and "Last" placeholder text on ancestry.com is offset too low (no longer centered vertically).

* STEPS TO REPRODUCE
1. Load <http://ancestry.com/>.

* RESULTS
The "First" and "Last" placeholders are rendered too low (no longer centered vertically).

* REGRESSION
Running bisect-builds and the internal autospade tool shows that this regressed with r103851.

<http://trac.webkit.org/changeset/103851>

* NOTES
This is the HTML in question:

<div class="dvCell">
  <span class="updnWatermark" style="display: inline; ">
    <label for="YourInformation_LastName">Last</label>
  </span>
  <input class="ln ancText validateText" id="YourInformation_LastName" maxlength="30" name="YourInformation.LastName" style="width:155px;" title="Last" type="text" value="">
</div>

[David Kilzer (:ddkilzer)]

<rdar://problem/10803331>

Created attachment 125372 [details]
Reduction

I’m not entirely sure that the new behavior is incorrect.

I think r103851 merely exposed a pre-existing issue. If you navigate to the URL, then enter this in the address field:
    javascript:var t = document.getElementById("YourInformation_FirstName").parentElement; t.insertBefore(document.createTextNode("z"), t.firstChild)

Then the placeholder text shifts downwards in r103850 as well. Perhaps the right thing to do in this bug is investigate this case (where the positioned element is not in leading whitespace) and figure out why WebKit behaves differently from Gecko.

The new behavior is the correct one. The uses a webkit-specific rule (enclosed in “@media screen and (-webkit-min-device-pixel-ratio:0)”) to set to ‘top’ property of the labels to 8px instead of the standard 1px, presumably as a workaround for WebKit’s incorrect behavior prior to r103851.

I am moving this to Evangelism because I don’t think WebKit should change.