Bug 77733 - [Chromium] Context menu on password field should not have search options
Summary: [Chromium] Context menu on password field should not have search options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 06:38 PST by Bernhard Bauer
Modified: 2012-02-08 12:16 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.69 KB, patch)
2012-02-03 06:39 PST, Bernhard Bauer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Bauer 2012-02-03 06:38:13 PST
[Chromium] Context menu on password field should not have search options
Comment 1 Bernhard Bauer 2012-02-03 06:39:26 PST
Created attachment 125317 [details]
Patch
Comment 2 Bernhard Bauer 2012-02-03 06:41:23 PST
See http://crbug.com/112498: 

"The context menu when selecting text in an input type=password field has an option to use "Search Google For"; that option should not be there. It simply searches google for a few dot characters."
Comment 3 jochen 2012-02-06 07:27:35 PST
LGTM
Comment 4 Adam Barth 2012-02-06 14:10:55 PST
Comment on attachment 125317 [details]
Patch

Should we write a unit test for this bug?  Maybe we should have a test in Chromium-land for it?
Comment 5 Bernhard Bauer 2012-02-06 14:20:54 PST
TBH, I'm not sure how we would write a non-flaky (in the way that interactive_ui_tests is flaky) test for this :-/
Comment 6 jochen 2012-02-08 11:50:39 PST
Comment on attachment 125317 [details]
Patch

I guess it should be possible to write a non-flaky browser test in chromium for this
Comment 7 Bernhard Bauer 2012-02-08 11:51:47 PST
SGTM.
Comment 8 WebKit Review Bot 2012-02-08 12:16:36 PST
Comment on attachment 125317 [details]
Patch

Clearing flags on attachment: 125317

Committed r107115: <http://trac.webkit.org/changeset/107115>
Comment 9 WebKit Review Bot 2012-02-08 12:16:40 PST
All reviewed patches have been landed.  Closing bug.