Speech input: fix fast/speech/bubble-position.html
(See Bug 77641)
Created attachment 125318 [details] Patch
Comment on attachment 125318 [details] Patch > var x = rect[0]; should we use parseInt(rect[0]) to be sure the calculations are done as an int?
(In reply to comment #3) > (From update of attachment 125318 [details]) > > var x = rect[0]; > should we use parseInt(rect[0]) to be sure the calculations are done as an int? Done.
Created attachment 125604 [details] Patch
looks good to me
Comment on attachment 125604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125604&action=review > LayoutTests/fast/speech/bubble-position.html:19 > + debug("rect is inside the iframe"); Better to use testPassed/testFailed instead of debug. testPassed("rect is inside the iframe"); > LayoutTests/fast/speech/bubble-position.html:23 > + debug("rect.y: " + y); testFailed("rect was outside the iframe. Actual rect.x: " + x + ", rect.y: " + y);
Thanks Tony! (In reply to comment #7) > (From update of attachment 125604 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125604&action=review > > > LayoutTests/fast/speech/bubble-position.html:19 > > + debug("rect is inside the iframe"); > > Better to use testPassed/testFailed instead of debug. Done. > > testPassed("rect is inside the iframe"); > > > LayoutTests/fast/speech/bubble-position.html:23 > > + debug("rect.y: " + y); > > testFailed("rect was outside the iframe. Actual rect.x: " + x + ", rect.y: " + y); Done.
Committed r106801: <http://trac.webkit.org/changeset/106801>