Bug 77732 - Speech input: fix fast/speech/bubble-position.html
Summary: Speech input: fix fast/speech/bubble-position.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 06:25 PST by Hans Wennborg
Modified: 2012-02-06 05:24 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.09 KB, patch)
2012-02-03 06:39 PST, Hans Wennborg
no flags Details | Formatted Diff | Diff
Patch (4.02 KB, patch)
2012-02-06 02:38 PST, Hans Wennborg
tonyg: review+
tonyg: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2012-02-03 06:25:01 PST
Speech input: fix fast/speech/bubble-position.html
Comment 1 Hans Wennborg 2012-02-03 06:26:50 PST
(See Bug 77641)
Comment 2 Hans Wennborg 2012-02-03 06:39:27 PST
Created attachment 125318 [details]
Patch
Comment 3 Satish Sampath 2012-02-03 12:03:38 PST
Comment on attachment 125318 [details]
Patch

> var x = rect[0];
should we use parseInt(rect[0]) to be sure the calculations are done as an int?
Comment 4 Hans Wennborg 2012-02-06 02:37:36 PST
(In reply to comment #3)
> (From update of attachment 125318 [details])
> > var x = rect[0];
> should we use parseInt(rect[0]) to be sure the calculations are done as an int?
Done.
Comment 5 Hans Wennborg 2012-02-06 02:38:01 PST
Created attachment 125604 [details]
Patch
Comment 6 Satish Sampath 2012-02-06 02:42:12 PST
looks good to me
Comment 7 Tony Gentilcore 2012-02-06 04:14:47 PST
Comment on attachment 125604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125604&action=review

> LayoutTests/fast/speech/bubble-position.html:19
> +        debug("rect is inside the iframe");

Better to use testPassed/testFailed instead of debug.

testPassed("rect is inside the iframe");

> LayoutTests/fast/speech/bubble-position.html:23
> +        debug("rect.y: " + y);

testFailed("rect was outside the iframe. Actual rect.x: " + x + ", rect.y: " + y);
Comment 8 Hans Wennborg 2012-02-06 05:14:36 PST
Thanks Tony!

(In reply to comment #7)
> (From update of attachment 125604 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125604&action=review
> 
> > LayoutTests/fast/speech/bubble-position.html:19
> > +        debug("rect is inside the iframe");
> 
> Better to use testPassed/testFailed instead of debug.
Done.

> 
> testPassed("rect is inside the iframe");
> 
> > LayoutTests/fast/speech/bubble-position.html:23
> > +        debug("rect.y: " + y);
> 
> testFailed("rect was outside the iframe. Actual rect.x: " + x + ", rect.y: " + y);
Done.
Comment 9 Hans Wennborg 2012-02-06 05:24:46 PST
Committed r106801: <http://trac.webkit.org/changeset/106801>