Bug 77732 – Speech input: fix fast/speech/bubble-position.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Hans Wennborg]

Speech input: fix fast/speech/bubble-position.html

[Hans Wennborg]

(See Bug 77641)

[Hans Wennborg]

Created attachment 125318 [details]
Patch

[Satish Sampath]

Comment on attachment 125318 [details]
Patch

> var x = rect[0];
should we use parseInt(rect[0]) to be sure the calculations are done as an int?

[Hans Wennborg]

(In reply to comment #3)
> (From update of attachment 125318 [details])
> > var x = rect[0];
> should we use parseInt(rect[0]) to be sure the calculations are done as an int?
Done.

[Hans Wennborg]

Created attachment 125604 [details]
Patch

[Satish Sampath]

looks good to me

[Tony Gentilcore]

Comment on attachment 125604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125604&action=review

> LayoutTests/fast/speech/bubble-position.html:19
> +        debug("rect is inside the iframe");

Better to use testPassed/testFailed instead of debug.

testPassed("rect is inside the iframe");

> LayoutTests/fast/speech/bubble-position.html:23
> +        debug("rect.y: " + y);

testFailed("rect was outside the iframe. Actual rect.x: " + x + ", rect.y: " + y);

[Hans Wennborg]

Thanks Tony!

(In reply to comment #7)
> (From update of attachment 125604 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125604&action=review
> 
> > LayoutTests/fast/speech/bubble-position.html:19
> > +        debug("rect is inside the iframe");
> 
> Better to use testPassed/testFailed instead of debug.
Done.

> 
> testPassed("rect is inside the iframe");
> 
> > LayoutTests/fast/speech/bubble-position.html:23
> > +        debug("rect.y: " + y);
> 
> testFailed("rect was outside the iframe. Actual rect.x: " + x + ", rect.y: " + y);
Done.

[Hans Wennborg]

Committed r106801: <http://trac.webkit.org/changeset/106801>