Bug 77727 - [Qt] Building when a top directory is named Source
Summary: [Qt] Building when a top directory is named Source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-02-03 02:50 PST by Allan Sandfeld Jensen
Modified: 2012-06-05 08:14 PDT (History)
3 users (show)

See Also:


Attachments
WorkAround (776 bytes, patch)
2012-03-13 10:07 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (1.53 KB, patch)
2012-06-05 05:26 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-02-03 02:50:47 PST
Building webkit from an checkout of webkit into /mnt/fileserver/Source/webkit fails.

The problem appears to be that the include path to generated files become /mnt/fileserver/webkit/Source/WebCore/generated (note the first 'Source' is missing). I have traced it to a setting ROOT_BUILD_DIR using $$replace. Using something more specific than $$replace would probably fix it, for instance only remove the last copy of SUBDIR.
Comment 1 Allan Sandfeld Jensen 2012-03-13 10:07:46 PDT
Created attachment 131651 [details]
WorkAround

A workaround make replace act as replace only at end.
Comment 2 Tor Arne Vestbø 2012-03-13 11:04:52 PDT
Comment on attachment 131651 [details]
WorkAround

the part after OUT_PWD, is a regex, let's fix it by making the regexp right
Comment 3 Allan Sandfeld Jensen 2012-06-05 05:26:22 PDT
Created attachment 145767 [details]
Patch
Comment 4 WebKit Review Bot 2012-06-05 08:13:56 PDT
Comment on attachment 145767 [details]
Patch

Clearing flags on attachment: 145767

Committed r119488: <http://trac.webkit.org/changeset/119488>
Comment 5 WebKit Review Bot 2012-06-05 08:14:00 PDT
All reviewed patches have been landed.  Closing bug.