Bug 77726 - Web Inspector: Retained size for classes is too conservative in heap profiler
Summary: Web Inspector: Retained size for classes is too conservative in heap profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 78411
  Show dependency treegraph
 
Reported: 2012-02-03 02:11 PST by Alexei Filippov
Modified: 2012-02-11 01:26 PST (History)
11 users (show)

See Also:


Attachments
Patch (5.02 KB, patch)
2012-02-03 02:24 PST, Alexei Filippov
no flags Details | Formatted Diff | Diff
Patch (5.06 KB, patch)
2012-02-03 07:17 PST, Alexei Filippov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Filippov 2012-02-03 02:11:59 PST
Retained size for all objects of particular class currently just shows size of the largest object of this class.
This estimate is too conservative and thus makes sorting by retained sizes (which is the default) useless.
Make it more precise.
Comment 1 Alexei Filippov 2012-02-03 02:24:56 PST
Created attachment 125296 [details]
Patch
Comment 2 Yury Semikhatsky 2012-02-03 05:55:25 PST
Comment on attachment 125296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125296&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:918
> +        function skip(node)

skip -> shouldSkip?

> Source/WebCore/inspector/front-end/HeapSnapshot.js:951
> +        var snapshot = this;

Just pass it as a parameter to forDominatedNodes.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:961
> +            var doms = snapshot._dominatedNodesOfNode(node);

doms -> dominatedNodeIndexes, we usually avoid abbreviations in the front-end code
Comment 3 Alexei Filippov 2012-02-03 07:17:52 PST
Created attachment 125320 [details]
Patch
Comment 4 WebKit Review Bot 2012-02-03 08:50:30 PST
Comment on attachment 125320 [details]
Patch

Clearing flags on attachment: 125320

Committed r106665: <http://trac.webkit.org/changeset/106665>
Comment 5 WebKit Review Bot 2012-02-03 08:50:35 PST
All reviewed patches have been landed.  Closing bug.