Retained size for all objects of particular class currently just shows size of the largest object of this class. This estimate is too conservative and thus makes sorting by retained sizes (which is the default) useless. Make it more precise.
Created attachment 125296 [details] Patch
Comment on attachment 125296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125296&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:918 > + function skip(node) skip -> shouldSkip? > Source/WebCore/inspector/front-end/HeapSnapshot.js:951 > + var snapshot = this; Just pass it as a parameter to forDominatedNodes. > Source/WebCore/inspector/front-end/HeapSnapshot.js:961 > + var doms = snapshot._dominatedNodesOfNode(node); doms -> dominatedNodeIndexes, we usually avoid abbreviations in the front-end code
Created attachment 125320 [details] Patch
Comment on attachment 125320 [details] Patch Clearing flags on attachment: 125320 Committed r106665: <http://trac.webkit.org/changeset/106665>
All reviewed patches have been landed. Closing bug.