WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
77726
Web Inspector: Retained size for classes is too conservative in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=77726
Summary
Web Inspector: Retained size for classes is too conservative in heap profiler
Alexei Filippov
Reported
2012-02-03 02:11:59 PST
Retained size for all objects of particular class currently just shows size of the largest object of this class. This estimate is too conservative and thus makes sorting by retained sizes (which is the default) useless. Make it more precise.
Attachments
Patch
(5.02 KB, patch)
2012-02-03 02:24 PST
,
Alexei Filippov
no flags
Details
Formatted Diff
Diff
Patch
(5.06 KB, patch)
2012-02-03 07:17 PST
,
Alexei Filippov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexei Filippov
Comment 1
2012-02-03 02:24:56 PST
Created
attachment 125296
[details]
Patch
Yury Semikhatsky
Comment 2
2012-02-03 05:55:25 PST
Comment on
attachment 125296
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=125296&action=review
> Source/WebCore/inspector/front-end/HeapSnapshot.js:918 > + function skip(node)
skip -> shouldSkip?
> Source/WebCore/inspector/front-end/HeapSnapshot.js:951 > + var snapshot = this;
Just pass it as a parameter to forDominatedNodes.
> Source/WebCore/inspector/front-end/HeapSnapshot.js:961 > + var doms = snapshot._dominatedNodesOfNode(node);
doms -> dominatedNodeIndexes, we usually avoid abbreviations in the front-end code
Alexei Filippov
Comment 3
2012-02-03 07:17:52 PST
Created
attachment 125320
[details]
Patch
WebKit Review Bot
Comment 4
2012-02-03 08:50:30 PST
Comment on
attachment 125320
[details]
Patch Clearing flags on attachment: 125320 Committed
r106665
: <
http://trac.webkit.org/changeset/106665
>
WebKit Review Bot
Comment 5
2012-02-03 08:50:35 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug