RESOLVED INVALID 77720
[EFL] Added new ewk_cookies_all_free function and removed ewk_cookies_cookie_free function from public API. 
https://bugs.webkit.org/show_bug.cgi?id=77720
Summary [EFL] Added new ewk_cookies_all_free function and removed ewk_cookies_cookie_...
Tomasz Morawski
Reported 2012-02-02 23:56:30 PST
Due to that there is no need to create Ewk_Cookie object directly (or event modify it) there is not need to have ewk_cookies_cookie_free function in public API. Insted of ewk_cookies_cookie_free function there is a need to have ewk_cookies_all_free to delete allocated list by ewk_cookies_get_all function. The API looks more useful after refactoring.
Attachments
added new function (4.38 KB, patch)
2012-02-03 00:47 PST, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomasz Morawski
Comment 1 2012-02-03 00:47:44 PST
Created attachment 125278 [details] added new function
Gyuyoung Kim
Comment 2 2012-03-06 23:44:04 PST
Comment on attachment 125278 [details] added new function View in context: https://bugs.webkit.org/attachment.cgi?id=125278&action=review > Source/WebKit/efl/ewk/ewk_cookies.cpp:35 > +#if USE(SOUP) We only support libsoup network backend. So, you don't need to use "USE(SOUP)" macro anymore. > Source/WebKit/efl/ewk/ewk_cookies.cpp:119 > +#if USE(SOUP) ditto.
Gyuyoung Kim
Comment 3 2012-04-04 02:16:44 PDT
Any update ?
Gyuyoung Kim
Comment 4 2012-08-27 19:01:54 PDT
Comment on attachment 125278 [details] added new function Cleared review? from attachment 125278 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.