Bug 77714 - Implement querySelector on ShadowRoot
Summary: Implement querySelector on ShadowRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 63601
  Show dependency treegraph
 
Reported: 2012-02-02 22:04 PST by Hayato Ito
Modified: 2012-02-06 20:47 PST (History)
6 users (show)

See Also:


Attachments
FAIL case (2.63 KB, patch)
2012-02-02 22:09 PST, Hayato Ito
no flags Details | Formatted Diff | Diff
implement querySelector (4.83 KB, patch)
2012-02-06 01:25 PST, Hayato Ito
no flags Details | Formatted Diff | Diff
Patch for landing (4.82 KB, patch)
2012-02-06 18:36 PST, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2012-02-02 22:04:31 PST
Now ShadowRoot inherits DocumentFragment both in WebCore and IDL, but it seems there is some cases that its querySelector APIs does not work correctly.
I'll attach a LayoutTest for error cases.
Comment 1 Hayato Ito 2012-02-02 22:09:45 PST
Created attachment 125259 [details]
FAIL case
Comment 2 Hayato Ito 2012-02-06 01:25:18 PST
Created attachment 125594 [details]
implement querySelector
Comment 3 Dimitri Glazkov (Google) 2012-02-06 09:10:35 PST
Comment on attachment 125594 [details]
implement querySelector

View in context: https://bugs.webkit.org/attachment.cgi?id=125594&action=review

> Source/WebCore/dom/SelectorQuery.cpp:101
> +static inline bool nodeIsRootNodeOfTreeScope(Node* node)

seems too long of a name. Maybe isTreeScopeRoot?
Comment 4 Hayato Ito 2012-02-06 18:30:19 PST
Thank you for the review.

(In reply to comment #3)
> (From update of attachment 125594 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125594&action=review
> 
> > Source/WebCore/dom/SelectorQuery.cpp:101
> > +static inline bool nodeIsRootNodeOfTreeScope(Node* node)
> 
> seems too long of a name. Maybe isTreeScopeRoot?

Sounds good. Let me rename it and land this patch.
Comment 5 Hayato Ito 2012-02-06 18:36:11 PST
Created attachment 125747 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-02-06 20:47:32 PST
Comment on attachment 125747 [details]
Patch for landing

Clearing flags on attachment: 125747

Committed r106902: <http://trac.webkit.org/changeset/106902>
Comment 7 WebKit Review Bot 2012-02-06 20:47:38 PST
All reviewed patches have been landed.  Closing bug.