Now ShadowRoot inherits DocumentFragment both in WebCore and IDL, but it seems there is some cases that its querySelector APIs does not work correctly. I'll attach a LayoutTest for error cases.
Created attachment 125259 [details] FAIL case
Created attachment 125594 [details] implement querySelector
Comment on attachment 125594 [details] implement querySelector View in context: https://bugs.webkit.org/attachment.cgi?id=125594&action=review > Source/WebCore/dom/SelectorQuery.cpp:101 > +static inline bool nodeIsRootNodeOfTreeScope(Node* node) seems too long of a name. Maybe isTreeScopeRoot?
Thank you for the review. (In reply to comment #3) > (From update of attachment 125594 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125594&action=review > > > Source/WebCore/dom/SelectorQuery.cpp:101 > > +static inline bool nodeIsRootNodeOfTreeScope(Node* node) > > seems too long of a name. Maybe isTreeScopeRoot? Sounds good. Let me rename it and land this patch.
Created attachment 125747 [details] Patch for landing
Comment on attachment 125747 [details] Patch for landing Clearing flags on attachment: 125747 Committed r106902: <http://trac.webkit.org/changeset/106902>
All reviewed patches have been landed. Closing bug.