Bug 77713 - Add the "V8" prefix to V8 specific IDL attributes
Summary: Add the "V8" prefix to V8 specific IDL attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency tree / graph
 
Reported: 2012-02-02 21:35 PST by Kentaro Hara
Modified: 2012-02-03 16:15 PST (History)
6 users (show)

See Also:

Attachments
Patch (46.66 KB, patch)
2012-02-02 21:40 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
rebased patch for commit (46.73 KB, patch)
2012-02-03 07:18 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-02 21:35:56 PST 
We should add the "V8" prefix to a V8 specific IDL attribute, as follows:

[EnabledAtRuntime] => [V8EnabledAtRuntime]
Comment 1 Kentaro Hara 2012-02-02 21:40:46 PST 
Created attachment 125258 [details]
Patch
Comment 2 Adam Barth 2012-02-03 00:57:17 PST 
Comment on attachment 125258 [details]
Patch

We had a dream of implementing EnabledAtRuntime for JSC, but there doesn't seem to be overly much demand.
Comment 3 WebKit Review Bot 2012-02-03 03:32:36 PST 
Comment on attachment 125258 [details]
Patch

Rejecting attachment 125258 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10576 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 10576.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11416288
Comment 4 Kentaro Hara 2012-02-03 07:18:14 PST 
Created attachment 125321 [details]
rebased patch for commit
Comment 5 WebKit Review Bot 2012-02-03 08:53:27 PST 
Comment on attachment 125321 [details]
rebased patch for commit

Clearing flags on attachment: 125321

Committed r106666: <http://trac.webkit.org/changeset/106666>