RESOLVED FIXED 77713
Add the "V8" prefix to V8 specific IDL attributes 
https://bugs.webkit.org/show_bug.cgi?id=77713
Summary Add the "V8" prefix to V8 specific IDL attributes
Kentaro Hara
Reported 2012-02-02 21:35:56 PST
We should add the "V8" prefix to a V8 specific IDL attribute, as follows: [EnabledAtRuntime] => [V8EnabledAtRuntime]
Attachments
Patch (46.66 KB, patch)
2012-02-02 21:40 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for commit (46.73 KB, patch)
2012-02-03 07:18 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-02 21:40:46 PST
Created attachment 125258 [details] Patch
Adam Barth
Comment 2 2012-02-03 00:57:17 PST
Comment on attachment 125258 [details] Patch We had a dream of implementing EnabledAtRuntime for JSC, but there doesn't seem to be overly much demand.
WebKit Review Bot
Comment 3 2012-02-03 03:32:36 PST
Comment on attachment 125258 [details] Patch Rejecting attachment 125258 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10576 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 10576. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11416288
Kentaro Hara
Comment 4 2012-02-03 07:18:14 PST
Created attachment 125321 [details] rebased patch for commit
WebKit Review Bot
Comment 5 2012-02-03 08:53:27 PST
Comment on attachment 125321 [details] rebased patch for commit Clearing flags on attachment: 125321 Committed r106666: <http://trac.webkit.org/changeset/106666>
Note You need to log in before you can comment on or make changes to this bug.