Bug 77708 - Add the "ObjC" prefix to ObjC specific IDL attributes
Summary: Add the "ObjC" prefix to ObjC specific IDL attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-02 20:13 PST by Kentaro Hara
Modified: 2012-02-03 07:09 PST (History)
9 users (show)

See Also:


Attachments
Patch (36.66 KB, patch)
2012-02-02 20:16 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for commit (37.36 KB, patch)
2012-02-03 01:29 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
patch for commit (37.36 KB, patch)
2012-02-03 01:30 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (30.30 KB, patch)
2012-02-03 06:52 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-02 20:13:26 PST
We can add the "ObjC" prefix to ObjC specific IDL attributes, as follows:

[Polymorphic] => [ObjCPolymorphic]
[OldStyleObjC] => [ObjCOldStyle]
[UsesView] => [ObjCUseDefaultView] (Note: Renamed for clarification)
Comment 1 Kentaro Hara 2012-02-02 20:16:58 PST
Created attachment 125247 [details]
Patch
Comment 2 Adam Barth 2012-02-03 00:51:05 PST
Comment on attachment 125247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125247&action=review

> Source/WebCore/ChangeLog:11
> +            [OldStyleObjC] => [ObjCOldStyle]

I like all of these except perhaps this one.  OldStyleObjC reads better to me.  Is there something more descriptive we can say?  ObjCLegacyInterface?  I'll admit that "old style" has always been a mystery to me.
Comment 3 Kentaro Hara 2012-02-03 00:53:25 PST
(In reply to comment #2)
> (From update of attachment 125247 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125247&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +            [OldStyleObjC] => [ObjCOldStyle]
> 
> I like all of these except perhaps this one.  OldStyleObjC reads better to me.  Is there something more descriptive we can say?  ObjCLegacyInterface?  I'll admit that "old style" has always been a mystery to me.

OK, then I'll rename it to ObjCLegacyInterface.
Comment 4 Adam Barth 2012-02-03 01:00:15 PST
> OK, then I'll rename it to ObjCLegacyInterface.

That was just a guess at a name.  I don't fully understand what the attribute does.
Comment 5 Adam Barth 2012-02-03 01:00:42 PST
Comment on attachment 125247 [details]
Patch

I'm going to mark this R+.  I trust you to do something reasonable with OldStyleObjC.
Comment 6 Kentaro Hara 2012-02-03 01:07:41 PST
(In reply to comment #4)
> > OK, then I'll rename it to ObjCLegacyInterface.
> 
> That was just a guess at a name.  I don't fully understand what the attribute does.

As far as I see from the comments like "generate the old style method names with un-named parameters, these methods are deprecated" and "All deprecated methods\
 need to be public, or should have the ObjCOldStyle IDL attribute removed", maybe the name would be [ObjCOldStyleMethod]. Thoughts? [OldStyleObjC] is not good since the name is not prefixed by "ObjC".
Comment 7 Adam Barth 2012-02-03 01:08:58 PST
ObjCLegacyUnamedParameters?
Comment 8 Kentaro Hara 2012-02-03 01:13:33 PST
(In reply to comment #7)
> ObjCLegacyUnamedParameters?

Yeah, this is more descriptive.  +1.
Comment 9 Kentaro Hara 2012-02-03 01:29:22 PST
Created attachment 125288 [details]
patch for commit
Comment 10 Kentaro Hara 2012-02-03 01:30:33 PST
Created attachment 125289 [details]
patch for commit
Comment 11 WebKit Review Bot 2012-02-03 04:14:56 PST
Comment on attachment 125289 [details]
patch for commit

Clearing flags on attachment: 125289

Committed r106648: <http://trac.webkit.org/changeset/106648>
Comment 12 Csaba Osztrogonác 2012-02-03 06:24:18 PST
Reopen, because it broke the build on Mac.
Comment 13 Kentaro Hara 2012-02-03 06:52:13 PST
Created attachment 125319 [details]
Patch
Comment 14 Kentaro Hara 2012-02-03 07:07:41 PST
Committed r106660: <http://trac.webkit.org/changeset/106660>