Bug 77706 - Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
Summary: Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency tree / graph
 
Reported: 2012-02-02 19:43 PST by Kentaro Hara
Modified: 2012-02-03 01:55 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.61 KB, patch)
2012-02-02 19:45 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-02 19:43:18 PST 
[LegacyParent] is a JSC-specific IDL attribute, and we can rename it to [JSLegacyParent]. Also, we need to remove dead code about [LegacyParent] from CodeGeneratorGObject.pm.
Comment 1 Kentaro Hara 2012-02-02 19:45:38 PST 
Created attachment 125244 [details]
Patch
Comment 2 Adam Barth 2012-02-03 00:47:20 PST 
Comment on attachment 125244 [details]
Patch

I think this rename names sense given that it's a legacy attribute.
Comment 3 Kentaro Hara 2012-02-03 00:51:21 PST 
(In reply to comment #2)
> (From update of attachment 125244 [details])
> I think this rename names sense given that it's a legacy attribute.

Do you mean we should rename it better?
Comment 4 Adam Barth 2012-02-03 00:59:38 PST 
> > I think this rename names sense given that it's a legacy attribute.
> 
> Do you mean we should rename it better?

I fail at typing.  I meant to say "I think this rename does make sense given that it's a legacy attribute."  :)
Comment 5 WebKit Review Bot 2012-02-03 01:55:10 PST 
Comment on attachment 125244 [details]
Patch

Clearing flags on attachment: 125244

Committed r106639: <http://trac.webkit.org/changeset/106639>
Comment 6 WebKit Review Bot 2012-02-03 01:55:15 PST 
All reviewed patches have been landed.  Closing bug.