Bug 7770 - Should only dispatch the khtmlTextInsertedEvent for high level editing operations
Summary: Should only dispatch the khtmlTextInsertedEvent for high level editing operat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Justin Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-14 16:57 PST by Justin Garcia
Modified: 2006-03-14 19:14 PST (History)
1 user (show)

See Also:


Attachments
patch (3.31 KB, patch)
2006-03-14 16:58 PST, Justin Garcia
adele: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2006-03-14 16:57:57 PST
The khtmlTextInsertedEvent is used to tell the new form fields that their inner div has been edited.  We don't need to tell them about every low level editing operation that we use to implement the higher level ones.  This also eliminates a big performance regression.
Comment 1 Justin Garcia 2006-03-14 16:58:50 PST
Created attachment 7068 [details]
patch
Comment 2 Adele Peterson 2006-03-14 17:03:50 PST
Comment on attachment 7068 [details]
patch

looks good! thanks for fixing this up.
Comment 3 Justin Garcia 2006-03-14 19:14:39 PST
We noticed that high level commands that go into an open TypingCommand don't go through EditCommand::apply, however they do go through appliedEditing/unappliedEditing/reappliedEditing on Frame, so that's where we dispatch.