Bug 77691 - Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use of device scale
Summary: Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-02-02 16:48 PST by Beth Dakin
Modified: 2012-02-03 11:30 PST (History)
3 users (show)

See Also:

Attachments
Patch (20.65 KB, patch)
2012-02-02 17:05 PST, Beth Dakin 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch trying to fix bots (20.33 KB, patch)
2012-02-02 17:44 PST, Beth Dakin 		aestes: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2012-02-02 16:48:44 PST 
Earlier this week in https://bugs.webkit.org/show_bug.cgi?id=77263 I fixed a bug where PlatformScreenMac was incorrectly relying on NSWindow. But in the process I introduced a layering violation, and just made WebKit2 do the same wrong thing as WebKit 1. Fix forthcoming. 

<rdar://problem/10754850>
Comment 1 Beth Dakin 2012-02-02 17:05:31 PST 
Created attachment 125213 [details]
Patch
Comment 2 Early Warning System Bot 2012-02-02 17:39:52 PST 
Comment on attachment 125213 [details]
Patch

Attachment 125213 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11416070
Comment 3 Beth Dakin 2012-02-02 17:44:23 PST 
Created attachment 125218 [details]
Patch trying to fix bots
Comment 4 Beth Dakin 2012-02-03 11:30:03 PST 
Thank Andy! Committed change: http://trac.webkit.org/changeset/106678