77688 – [chromium] add support for --makeargs to the ninja-based build

Bug 77688 - [chromium] add support for --makeargs to the ninja-based build

Summary: [chromium] add support for --makeargs to the ninja-based build

Attachments
Patch (1.42 KB, patch) 2012-02-02 15:45 PST, jochen	no flags	Details \| Formatted Diff \| Diff
Patch (1.33 KB, patch) 2012-02-02 16:45 PST, jochen	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description jochen 2012-02-02 15:44:17 PST

[chromium] add support for --makeargs to the ninja-based build

Comment 1 jochen 2012-02-02 15:45:18 PST

Created attachment 125204 [details]
Patch

Comment 2 jochen 2012-02-02 16:45:14 PST

Created attachment 125209 [details]
Patch

Comment 3 jochen 2012-02-02 16:46:00 PST

Comment on attachment 125209 [details]
Patch

Removed the default -j flag, as requested by Nico, as ninja has a sensible default

Comment 4 WebKit Review Bot 2012-02-02 19:19:11 PST

Comment on attachment 125209 [details]
Patch

Clearing flags on attachment: 125209

Committed r106617: <http://trac.webkit.org/changeset/106617>

Comment 5 WebKit Review Bot 2012-02-02 19:19:15 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Nico Weber 2012-02-03 15:29:49 PST

Thanks for the change, and for playing with ninja :-)

Out of curiosity, what do you use this for?

Comment 7 jochen 2012-02-03 23:50:30 PST

To pass -j300 so ninja uses my incredible computing powah!