Bug 77677 – Implement current executable path finding for win32

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Kalev Lember]

The WTF helper for getting the binary path that was added in r101710
left out the win32 implementation. Fix this.

[Kalev Lember]

Created attachment 125173 [details]
Implement current executable path finding for win32

[WebKit Review Bot]

Attachment 125173 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/gobject/GlibUtilities.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 125173 [details]
Implement current executable path finding for win32

View in context: https://bugs.webkit.org/attachment.cgi?id=125173&action=review

r- only because you are not a committer and cannot fix the style nit before landing.

>> Source/JavaScriptCore/wtf/gobject/GlibUtilities.cpp:25
>> +#if OS(WINDOWS)
>> +#include <wtf/text/WTFString.h>
>> +#include <windows.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please fix this simple style nit.

[Kalev Lember]

Created attachment 125179 [details]
ver 2: Updated patch with headers sorted

Thanks for the review, this should hopefully pass the bot.

[WebKit Review Bot]

Comment on attachment 125179 [details]
ver 2: Updated patch with headers sorted

Clearing flags on attachment: 125179

Committed r106595: <http://trac.webkit.org/changeset/106595>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.