Bug 77677 - Implement current executable path finding for win32
: Implement current executable path finding for win32
Status: RESOLVED FIXED
: WebKit
WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-02-02 13:17 PST by
Modified: 2012-02-02 15:04 PST (History)


Attachments
Implement current executable path finding for win32 (2.11 KB, patch)
2012-02-02 13:18 PST, Kalev Lember
mrobinson: review-
Review Patch | Details | Formatted Diff | Diff
ver 2: Updated patch with headers sorted (2.11 KB, patch)
2012-02-02 13:37 PST, Kalev Lember
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-02-02 13:17:43 PST
The WTF helper for getting the binary path that was added in r101710
left out the win32 implementation. Fix this.
------- Comment #1 From 2012-02-02 13:18:22 PST -------
Created an attachment (id=125173) [details]
Implement current executable path finding for win32
------- Comment #2 From 2012-02-02 13:22:08 PST -------
Attachment 125173 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/gobject/GlibUtilities.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2012-02-02 13:29:35 PST -------
(From update of attachment 125173 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=125173&action=review

r- only because you are not a committer and cannot fix the style nit before landing.

>> Source/JavaScriptCore/wtf/gobject/GlibUtilities.cpp:25
>> +#if OS(WINDOWS)
>> +#include <wtf/text/WTFString.h>
>> +#include <windows.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Please fix this simple style nit.
------- Comment #4 From 2012-02-02 13:37:31 PST -------
Created an attachment (id=125179) [details]
ver 2: Updated patch with headers sorted

Thanks for the review, this should hopefully pass the bot.
------- Comment #5 From 2012-02-02 15:03:58 PST -------
(From update of attachment 125179 [details])
Clearing flags on attachment: 125179

Committed r106595: <http://trac.webkit.org/changeset/106595>
------- Comment #6 From 2012-02-02 15:04:02 PST -------
All reviewed patches have been landed.  Closing bug.