Bug 77672 - Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
Summary: Incorrect statistics shown when running run-webkit-tests with --repeat-each o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-02 12:53 PST by Sergio Villar Senin
Modified: 2012-02-06 01:07 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.97 KB, patch)
2012-02-02 12:57 PST, Sergio Villar Senin
no flags Details | Formatted Diff | Diff
Patch (7.07 KB, patch)
2012-02-03 04:46 PST, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2012-02-02 12:53:21 PST
Both --repeat-each and --iterations are not taken into account when showing progress and summary information in run-webkit-tests. For example this is what we get if we execute:

run-webkit-tests --iterations 10 sometest

Testing (100%): 1 run as expected, 0 didn't, 0 left
[...]
Testing (700%): 7 run as expected, 0 didn't, -6 left
[...]

10 tests ran as expected (-9 didn't run).
Comment 1 Sergio Villar Senin 2012-02-02 12:57:44 PST
Created attachment 125169 [details]
Patch
Comment 2 Adam Barth 2012-02-02 13:13:15 PST
Comment on attachment 125169 [details]
Patch

Looks reasonable.  How do we test this change?
Comment 3 Sergio Villar Senin 2012-02-03 04:46:00 PST
Created attachment 125308 [details]
Patch
Comment 4 Sergio Villar Senin 2012-02-06 01:07:31 PST
Comment on attachment 125308 [details]
Patch

Clearing flags on attachment: 125308

Committed r106784: <http://trac.webkit.org/changeset/106784>
Comment 5 Sergio Villar Senin 2012-02-06 01:07:38 PST
All reviewed patches have been landed.  Closing bug.