Bug 77670 - The overhang area layer should have a linen background
Summary: The overhang area layer should have a linen background
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-02 12:52 PST by Anders Carlsson
Modified: 2012-02-02 13:19 PST (History)
0 users

See Also:


Attachments
Patch (7.95 KB, patch)
2012-02-02 12:54 PST, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-02-02 12:52:24 PST
The overhang area layer should have a linen background
Comment 1 Anders Carlsson 2012-02-02 12:54:23 PST
Created attachment 125166 [details]
Patch
Comment 2 Andreas Kling 2012-02-02 13:10:46 PST
Comment on attachment 125166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125166&action=review

> Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:94
> +#if !DISABLE_SCROLL_POSITION_CLAMPING

Double negatives aren't not harder to read.

> Source/WebCore/platform/mac/ScrollbarThemeMac.h:85
> +    virtual void setUpOverhangAreasLayerContents(GraphicsLayer*) override;

override -> OVERRIDE

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:441
> +

Unnecessary new whitespace.
Comment 3 Anders Carlsson 2012-02-02 13:19:06 PST
Committed r106588: <http://trac.webkit.org/changeset/106588>