WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
77669
Release build debugging should be easier
https://bugs.webkit.org/show_bug.cgi?id=77669
Summary
Release build debugging should be easier
Filip Pizlo
Reported
2012-02-02 12:45:13 PST
JavaScriptCore has loads of #ifndef NDEBUG guards for helper methods that print the internal representation (bytecode, DFG, JSValue). While this saves some space in release binaries, it also makes it really hard to do meaningful debugging while in release mode. Not to mention it adds more preprocessor noise. It would be better if we just let the various debugging helpers compiled in always, so we can always call them even when in a release build.
Attachments
the patch
(26.26 KB, patch)
2012-02-02 12:47 PST
,
Filip Pizlo
barraclough
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2012-02-02 12:47:54 PST
Created
attachment 125163
[details]
the patch No performance impact. 0.8% increase in the size of the JavaScriptCore framework.
Gavin Barraclough
Comment 2
2012-02-02 12:54:04 PST
Comment on
attachment 125163
[details]
the patch It would be great at some point if we can harden the code so that that debugOffset cannot be abused in a way that would introduce bugs.
Filip Pizlo
Comment 3
2012-02-02 13:50:19 PST
Landed in
http://trac.webkit.org/changeset/106590
Filip Pizlo
Comment 4
2012-02-06 17:35:29 PST
<
rdar://problem/10817157
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug