In audio-testing.js, we have function createImpulseBuffer(context, sampleFrameLength) { var audioBuffer = context.createBuffer(1, 1000, context.sampleRate); That 1000 should be sampleFrameLength.
Created attachment 125183 [details] Patch
Wow, you wrote a layout test to test another layout test function - very meta! Honestly, I would remove the test and just fix the existing layout test function in the .js file.
(In reply to comment #2) > Wow, you wrote a layout test to test another layout test function - very meta! > > Honestly, I would remove the test and just fix the existing layout test function in the .js file. Yeah, I wasn't going to, but then thought if we had had a test, this wouldn't have happened. I'll remove it and upload a new version shortly.
Created attachment 125193 [details] Patch
Looks good.
Ken, can you take a quick look at this one line change?
Comment on attachment 125193 [details] Patch Looks fine. rs=me
Comment on attachment 125193 [details] Patch Clearing flags on attachment: 125193 Committed r106974: <http://trac.webkit.org/changeset/106974>
All reviewed patches have been landed. Closing bug.