RESOLVED FIXED Bug 77665
createImpulseBuffer uses incorrect length 
https://bugs.webkit.org/show_bug.cgi?id=77665
Summary createImpulseBuffer uses incorrect length
Raymond Toy
Reported 2012-02-02 12:01:09 PST
In audio-testing.js, we have function createImpulseBuffer(context, sampleFrameLength) { var audioBuffer = context.createBuffer(1, 1000, context.sampleRate); That 1000 should be sampleFrameLength.
Attachments
Patch (5.05 KB, patch)
2012-02-02 13:54 PST, Raymond Toy 		no flags
DetailsFormatted DiffDiff
Patch (1.42 KB, patch)
2012-02-02 14:46 PST, Raymond Toy 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raymond Toy
Comment 1 2012-02-02 13:54:23 PST
Created attachment 125183 [details] Patch
Chris Rogers
Comment 2 2012-02-02 14:25:59 PST
Wow, you wrote a layout test to test another layout test function - very meta! Honestly, I would remove the test and just fix the existing layout test function in the .js file.
Raymond Toy
Comment 3 2012-02-02 14:42:31 PST
(In reply to comment #2) > Wow, you wrote a layout test to test another layout test function - very meta! > > Honestly, I would remove the test and just fix the existing layout test function in the .js file. Yeah, I wasn't going to, but then thought if we had had a test, this wouldn't have happened. I'll remove it and upload a new version shortly.
Raymond Toy
Comment 4 2012-02-02 14:46:25 PST
Created attachment 125193 [details] Patch
Chris Rogers
Comment 5 2012-02-02 15:08:39 PST
Looks good.
Raymond Toy
Comment 6 2012-02-07 11:19:52 PST
Ken, can you take a quick look at this one line change?
Kenneth Russell
Comment 7 2012-02-07 11:29:04 PST
Comment on attachment 125193 [details] Patch Looks fine. rs=me
WebKit Review Bot
Comment 8 2012-02-07 12:16:24 PST
Comment on attachment 125193 [details] Patch Clearing flags on attachment: 125193 Committed r106974: <http://trac.webkit.org/changeset/106974>
WebKit Review Bot
Comment 9 2012-02-07 12:16:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.