WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
77649
Upstream targetType usage on ResourceRequest for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=77649
Summary
Upstream targetType usage on ResourceRequest for BlackBerry port
Rob Buis
Reported
2012-02-02 09:08:18 PST
We rely on targetType usage, same as chromium port does.
Attachments
Patch
(5.01 KB, patch)
2012-02-02 09:12 PST
,
Rob Buis
tonikitoo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Rob Buis
Comment 1
2012-02-02 09:12:44 PST
Created
attachment 125145
[details]
Patch
Antonio Gomes
Comment 2
2012-02-02 10:47:57 PST
Comment on
attachment 125145
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=125145&action=review
> Source/WebCore/platform/network/blackberry/ResourceRequest.h:53 > + enum TargetType { > + TargetIsMainFrame, > + TargetIsSubframe, > + TargetIsSubresource, // Resource is a generic subresource. (Generally a specific type should be specified) > + TargetIsStyleSheet, > + TargetIsScript, > + TargetIsFontResource, > + TargetIsImage, > + TargetIsObject, > + TargetIsMedia, > + TargetIsWorker, > + TargetIsSharedWorker, > + TargetIsPrefetch, > + TargetIsPrerender, > + TargetIsFavicon, > + TargetIsXHR, > + TargetIsTextTrack, > + TargetIsUnspecified, > + };
maybe we should move it to the resourcerequestbase class, and only declare it for chromium and blackberry?
Rob Buis
Comment 3
2012-02-02 11:07:55 PST
(In reply to
comment #2
)
> (From update of
attachment 125145
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=125145&action=review
> > > Source/WebCore/platform/network/blackberry/ResourceRequest.h:53 > > + enum TargetType { > > + TargetIsMainFrame, > > + TargetIsSubframe, > > + TargetIsSubresource, // Resource is a generic subresource. (Generally a specific type should be specified) > > + TargetIsStyleSheet, > > + TargetIsScript, > > + TargetIsFontResource, > > + TargetIsImage, > > + TargetIsObject, > > + TargetIsMedia, > > + TargetIsWorker, > > + TargetIsSharedWorker, > > + TargetIsPrefetch, > > + TargetIsPrerender, > > + TargetIsFavicon, > > + TargetIsXHR, > > + TargetIsTextTrack, > > + TargetIsUnspecified, > > + }; > > maybe we should move it to the resourcerequestbase class, and only declare it for chromium and blackberry?
This is a good idea, but would require feedback from Chromium folks. Note that our ResourceRequest implementation is different, for instance we add setAnchorText to the API, I am sure chromium adds other things. Cheers, Rob.
Rob Buis
Comment 4
2012-02-03 07:00:20 PST
Landed in
r106655
, closing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug