RESOLVED FIXED 77627
Web Inspector: enable editing of selected rows on single click in elements panel. 
https://bugs.webkit.org/show_bug.cgi?id=77627
Summary Web Inspector: enable editing of selected rows on single click in elements pa...
Pavel Feldman
Reported 2012-02-02 04:36:59 PST
Single click on tag or attribute of the selected row will initiate editing.
Attachments
Patch (3.92 KB, patch)
2012-02-02 04:41 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] Same with proper drag / context menu handling. (4.21 KB, patch)
2012-02-02 05:17 PST, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-02-02 04:41:10 PST
Created attachment 125114 [details] Patch
Pavel Feldman
Comment 2 2012-02-02 05:17:20 PST
Created attachment 125119 [details] [Patch] Same with proper drag / context menu handling.
Vsevolod Vlasov
Comment 3 2012-02-02 05:38:10 PST
Comment on attachment 125119 [details] [Patch] Same with proper drag / context menu handling. View in context: https://bugs.webkit.org/attachment.cgi?id=125119&action=review > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:998 > + this._isSingleClickCandidate; Please remove that.
Pavel Feldman
Comment 4 2012-02-02 06:28:57 PST
Committed r106552: <http://trac.webkit.org/changeset/106552>
Joseph Pecoraro
Comment 5 2012-02-02 10:38:23 PST
Would this make it harder to copy/paste from the tree outline? I suppose "Right Click > Copy as HTML" will still be available.
Timothy Hatcher
Comment 6 2012-02-02 10:46:13 PST
To me the Elements tree would become a landmine, making it harder to select a node without having to press escape to cancel editing.
Pavel Feldman
Comment 7 2012-02-02 11:20:45 PST
(In reply to comment #6) > To me the Elements tree would become a landmine, making it harder to select a node without having to press escape to cancel editing. It only toggles editing in case you left-click on the selected row. I've spent some time playing with it and it did not make me angry. If it does annoy you, I'm ready to roll it out. Btw, I landed an experiment that enables styles editing with single click. Also did not annoy me. Could you play with it?
Note You need to log in before you can comment on or make changes to this bug.