Bug 77606 - The third argument of addEventListener/removeEventListener of PeerConnection should be optional
Summary: The third argument of addEventListener/removeEventListener of PeerConnection ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency tree / graph
 
Reported: 2012-02-01 23:18 PST by Kentaro Hara
Modified: 2012-02-02 00:24 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.09 KB, patch)
2012-02-01 23:22 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-01 23:18:17 PST 
We need to correct typo in PeerConnection.idl:

Before:
void addEventListener(in DOMString type, in EventListener listener, in [optional] boolean useCapture);
void removeEventListener(in DOMString type, in EventListener listener, in [optional] boolean useCapture);

After:
void addEventListener(in DOMString type, in EventListener listener, in [Optional] boolean useCapture);
void removeEventListener(in DOMString type, in EventListener listener, in [Optional] boolean useCapture);
Comment 1 Kentaro Hara 2012-02-01 23:22:11 PST 
Created attachment 125082 [details]
Patch
Comment 2 Adam Barth 2012-02-01 23:40:01 PST 
Comment on attachment 125082 [details]
Patch

Thanks for the test.
Comment 3 WebKit Review Bot 2012-02-02 00:24:17 PST 
Comment on attachment 125082 [details]
Patch

Clearing flags on attachment: 125082

Committed r106539: <http://trac.webkit.org/changeset/106539>
Comment 4 WebKit Review Bot 2012-02-02 00:24:24 PST 
All reviewed patches have been landed.  Closing bug.