Bug 77604 - [Qt] Inspector Disabled build breaks (if Javascript debugger is not disabled)
Summary: [Qt] Inspector Disabled build breaks (if Javascript debugger is not disabled)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-01 22:36 PST by Sriram Neelakandan
Modified: 2012-02-03 04:02 PST (History)
3 users (show)

See Also:

Attachments
patch to disable JS Debugger if Inspector is disabled (677 bytes, patch)
2012-02-01 22:37 PST, Sriram Neelakandan 		no flags Details | Formatted Diff | Diff
patch to disable JS Debugger if Inspector is disabled (with changeLog) (1.17 KB, patch)
2012-02-03 01:22 PST, Sriram Neelakandan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sriram Neelakandan 2012-02-01 22:36:30 PST 
I use the following command line to build-webkit-qt from Trunk (using Qt-4.8.0)

./Tools/Scripts/build-webkit --no-video --no-svg --no-mathml --no-inspector --no-3d-canvas --no-webkit2 --no-web-audio --debug --qt


The Inspector disabled build breaks with the following error:

../../../../Source/WebCore/bindings/js/ScriptProfiler.h:56:23: error: ‘InspectorValue’ was not declared in this scope
../../../../Source/WebCore/bindings/js/ScriptProfiler.h:56:37: error: template argument 1 is invalid


I think this may be due to http://trac.webkit.org/changeset/102366/trunk/Source/WebCore/bindings/js/ScriptProfiler.h

Attaching a patch to disable Javascript Debugger if Inspector is disabled in features.prf
Comment 1 Sriram Neelakandan 2012-02-01 22:37:46 PST 
Created attachment 125081 [details]
patch to disable JS Debugger if Inspector is disabled
Comment 2 Zoltan Horvath 2012-02-03 00:55:38 PST 
Looks reasonable for me. Please add changelog to the patch!
Comment 3 Sriram Neelakandan 2012-02-03 01:22:58 PST 
Created attachment 125285 [details]
patch to disable JS Debugger if Inspector is disabled (with changeLog)
Comment 4 Tor Arne Vestbø 2012-02-03 03:08:23 PST 
Comment on attachment 125285 [details]
patch to disable JS Debugger if Inspector is disabled (with changeLog)

thanks
Comment 5 WebKit Review Bot 2012-02-03 04:02:45 PST 
Comment on attachment 125285 [details]
patch to disable JS Debugger if Inspector is disabled (with changeLog)

Clearing flags on attachment: 125285

Committed r106647: <http://trac.webkit.org/changeset/106647>
Comment 6 WebKit Review Bot 2012-02-03 04:02:51 PST 
All reviewed patches have been landed.  Closing bug.