RESOLVED FIXED 77601
Rename [CheckFrameSecurity] and [SVGCheckSecurity] to [AllowAccessToNode] 
https://bugs.webkit.org/show_bug.cgi?id=77601
Summary Rename [CheckFrameSecurity] and [SVGCheckSecurity] to [AllowAccessToNode]
Kentaro Hara
Reported 2012-02-01 21:43:16 PST
[CheckFrameSecurity] and [SVGCheckSecurity] have the same meaning; i.e. generate code to check allowAccessToNode() for a given attribute or method. We can rename them to [AllowAccessToNode].
Attachments
Patch (11.61 KB, patch)
2012-02-01 21:54 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for commit (11.60 KB, patch)
2012-02-01 22:18 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-01 21:54:00 PST
Created attachment 125076 [details] Patch
Adam Barth
Comment 2 2012-02-01 22:02:37 PST
Comment on attachment 125076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125076&action=review > Source/WebCore/ChangeLog:10 > + to [AllowAccessToNode]. [AllowAccessToNode] isn't the best name. It sounds like we're instructing the system to allow the access rather than to check for access. Maybe [CheckAccessToNode] or [CheckAccessToResult] ?
Kentaro Hara
Comment 3 2012-02-01 22:18:57 PST
Created attachment 125080 [details] patch for commit
Kentaro Hara
Comment 4 2012-02-01 22:19:50 PST
Comment on attachment 125076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125076&action=review >> Source/WebCore/ChangeLog:10 >> + to [AllowAccessToNode]. > > [AllowAccessToNode] isn't the best name. It sounds like we're instructing the system to allow the access rather than to check for access. Maybe [CheckAccessToNode] or [CheckAccessToResult] ? Renamed to [CheckAccessToNode] and committed. Thanks!
WebKit Review Bot
Comment 5 2012-02-02 00:00:35 PST
Comment on attachment 125080 [details] patch for commit Clearing flags on attachment: 125080 Committed r106536: <http://trac.webkit.org/changeset/106536>
Note You need to log in before you can comment on or make changes to this bug.