Bug 77600 - Refactor MarkedBlock::SizeClass into a separate class
Summary: Refactor MarkedBlock::SizeClass into a separate class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 77761
  Show dependency tree / graph
 
Reported: 2012-02-01 21:17 PST by Mark Hahnenberg
Modified: 2012-02-03 11:49 PST (History)
3 users (show)

See Also:

Attachments
Patch (30.89 KB, patch)
2012-02-01 21:23 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (34.07 KB, patch)
2012-02-01 22:17 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Fixing windows (35.23 KB, patch)
2012-02-02 08:17 PST, Mark Hahnenberg 		ggaren: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-02-01 21:17:37 PST 
In preparation for splitting MarkedSpace into multiple "sub-spaces" with slight variations in behavior, we should refactor SizeClass into its own separate class, since it already serves this purpose to a limited degree. We'll rename it to MarkedAllocator and treat it externally as a bag of MarkedBlocks. MarkedSpace will then just be a collection of these MarkedAllocators, each of which can have a variety of policies and manage its own MarkedBlocks according to these policies. MarkedAllocator will take on all of the dirty work of allocation out of MarkedBlocks that MarkedSpace did have. So the heap is now organized as follows:

Heap (which contains...)
-MarkedSpace (which contains multiple...)
--MarkedAllocator (which contains multiple...)
---MarkedBlock
Comment 1 Mark Hahnenberg 2012-02-01 21:23:51 PST 
Created attachment 125074 [details]
Patch
Comment 2 Early Warning System Bot 2012-02-01 21:43:42 PST 
Comment on attachment 125074 [details]
Patch

Attachment 125074 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11388709
Comment 3 Gyuyoung Kim 2012-02-01 22:08:42 PST 
Comment on attachment 125074 [details]
Patch

Attachment 125074 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11382012
Comment 4 Mark Hahnenberg 2012-02-01 22:17:02 PST 
Created attachment 125079 [details]
Patch
Comment 5 Mark Hahnenberg 2012-02-02 08:17:48 PST 
Created attachment 125135 [details]
Fixing windows
Comment 6 Geoffrey Garen 2012-02-03 10:28:15 PST 
Comment on attachment 125135 [details]
Fixing windows

r=me
Comment 7 WebKit Review Bot 2012-02-03 10:43:25 PST 
Comment on attachment 125135 [details]
Fixing windows

Rejecting attachment 125135 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ing file Source/JavaScriptCore/heap/Heap.h
patching file Source/JavaScriptCore/heap/MarkedAllocator.cpp
patching file Source/JavaScriptCore/heap/MarkedAllocator.h
patching file Source/JavaScriptCore/heap/MarkedSpace.cpp
patching file Source/JavaScriptCore/heap/MarkedSpace.h
patching file Source/JavaScriptCore/jit/JITInlineMethods.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Geoffrey G..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11423318
Comment 8 Mark Hahnenberg 2012-02-03 11:21:42 PST 
Committed r106676: <http://trac.webkit.org/changeset/106676>