Bug 77600 – Refactor MarkedBlock::SizeClass into a separate class

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

In preparation for splitting MarkedSpace into multiple "sub-spaces" with slight variations in behavior, we should refactor SizeClass into its own separate class, since it already serves this purpose to a limited degree. We'll rename it to MarkedAllocator and treat it externally as a bag of MarkedBlocks. MarkedSpace will then just be a collection of these MarkedAllocators, each of which can have a variety of policies and manage its own MarkedBlocks according to these policies. MarkedAllocator will take on all of the dirty work of allocation out of MarkedBlocks that MarkedSpace did have. So the heap is now organized as follows:

Heap (which contains...)
-MarkedSpace (which contains multiple...)
--MarkedAllocator (which contains multiple...)
---MarkedBlock

[Mark Hahnenberg]

Created attachment 125074 [details]
Patch

[Early Warning System Bot]

Comment on attachment 125074 [details]
Patch

Attachment 125074 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11388709

[Gyuyoung Kim]

Comment on attachment 125074 [details]
Patch

Attachment 125074 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11382012

[Mark Hahnenberg]

Created attachment 125079 [details]
Patch

[Mark Hahnenberg]

Created attachment 125135 [details]
Fixing windows

[Geoffrey Garen]

Comment on attachment 125135 [details]
Fixing windows

r=me

[WebKit Review Bot]

Comment on attachment 125135 [details]
Fixing windows

Rejecting attachment 125135 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ing file Source/JavaScriptCore/heap/Heap.h
patching file Source/JavaScriptCore/heap/MarkedAllocator.cpp
patching file Source/JavaScriptCore/heap/MarkedAllocator.h
patching file Source/JavaScriptCore/heap/MarkedSpace.cpp
patching file Source/JavaScriptCore/heap/MarkedSpace.h
patching file Source/JavaScriptCore/jit/JITInlineMethods.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Geoffrey G..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11423318

[Mark Hahnenberg]

Committed r106676: <http://trac.webkit.org/changeset/106676>