[GenerateConstructor] is used in some IDL files but it is not implemented in code generators. I could not find any history about [GenerateConstructor] in code generators. Now we can remove them from the following IDL files: ./html/DOMSettableTokenList.idl ./html/DOMTokenList.idl ./webaudio/AudioPannerNode.idl ./dom/DOMStringList.idl ./svg/SVGFEConvolveMatrixElement.idl Maybe we want to replace it with [Constructor] eventually, but currently no tests are written for their constructors (e.g. "new DOMTokenList()"). So simply removing them would make sense.
Created attachment 125070 [details] Patch
Comment on attachment 125070 [details] Patch Ok. It's too bad you didn't find any history here. I suspect this got cargo-cult copied, at least to AudioPannerNode.
Comment on attachment 125070 [details] Patch Clearing flags on attachment: 125070 Committed r106532: <http://trac.webkit.org/changeset/106532>
All reviewed patches have been landed. Closing bug.
GenerateConstructor was made obsolete by r52534 and I found that revision just by doing a search for GenerateConstructor in ChangeLog files. A good technique for researching past history.
I mean http://trac.webkit.org/changeset/52534
Darin: Thanks for the info! (I was just doing "git blame CodeGeneratorJS.pm" for several revisions.)
(In reply to comment #7) > Darin: Thanks for the info! (I was just doing "git blame CodeGeneratorJS.pm" for several revisions.) I guess this is a great example to bring up when people say “ChangeLog is no good; svn/git history is all you need and is way better anyway”.