RESOLVED FIXED 77598
Remove [GenerateConstructor] from IDL files 
https://bugs.webkit.org/show_bug.cgi?id=77598
Summary Remove [GenerateConstructor] from IDL files
Kentaro Hara
Reported 2012-02-01 20:51:09 PST
[GenerateConstructor] is used in some IDL files but it is not implemented in code generators. I could not find any history about [GenerateConstructor] in code generators. Now we can remove them from the following IDL files: ./html/DOMSettableTokenList.idl ./html/DOMTokenList.idl ./webaudio/AudioPannerNode.idl ./dom/DOMStringList.idl ./svg/SVGFEConvolveMatrixElement.idl Maybe we want to replace it with [Constructor] eventually, but currently no tests are written for their constructors (e.g. "new DOMTokenList()"). So simply removing them would make sense.
Attachments
Patch (3.73 KB, patch)
2012-02-01 20:57 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-01 20:57:34 PST
Created attachment 125070 [details] Patch
Adam Barth
Comment 2 2012-02-01 21:08:36 PST
Comment on attachment 125070 [details] Patch Ok. It's too bad you didn't find any history here. I suspect this got cargo-cult copied, at least to AudioPannerNode.
WebKit Review Bot
Comment 3 2012-02-01 22:24:43 PST
Comment on attachment 125070 [details] Patch Clearing flags on attachment: 125070 Committed r106532: <http://trac.webkit.org/changeset/106532>
WebKit Review Bot
Comment 4 2012-02-01 22:24:48 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2012-02-02 18:20:47 PST
GenerateConstructor was made obsolete by r52534 and I found that revision just by doing a search for GenerateConstructor in ChangeLog files. A good technique for researching past history.
Darin Adler
Comment 6 2012-02-02 18:21:00 PST
I mean http://trac.webkit.org/changeset/52534
Kentaro Hara
Comment 7 2012-02-02 18:22:24 PST
Darin: Thanks for the info! (I was just doing "git blame CodeGeneratorJS.pm" for several revisions.)
Darin Adler
Comment 8 2012-02-07 12:22:52 PST
(In reply to comment #7) > Darin: Thanks for the info! (I was just doing "git blame CodeGeneratorJS.pm" for several revisions.) I guess this is a great example to bring up when people say “ChangeLog is no good; svn/git history is all you need and is way better anyway”.
Note You need to log in before you can comment on or make changes to this bug.