Created attachment 125051 [details] Patch. In order to prevent conflict between zoom and contents size change, layout flag is newly added.
Attachment 125051 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 125060 [details] Patch updated. Add bug ID.
Attachment 125060 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 125062 [details] Patch.
Comment on attachment 125062 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=125062&action=review > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1802 > + priv->changed.layout = true; I'm not good guys for the naming, but why don't you use contentsSize instead of layout ? This flag looks to mark when contents resized.
Created attachment 125223 [details] Patch updated. Replace layout flag with contentsSize flag.
(In reply to comment #6) > Created an attachment (id=125223) [details] > Patch updated. > > Replace layout flag with contentsSize flag. LGTM
Created attachment 125239 [details] Patch updated. Just move reset of contentsSize flag into existing condition block.
Comment on attachment 125239 [details] Patch updated. View in context: https://bugs.webkit.org/attachment.cgi?id=125239&action=review r=me > Source/WebKit/efl/ChangeLog:9 > + ewk_tiled_bakcing_store can not detect the conflict between them. Typo, ewk_tiled_backing_store. > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1377 > + if (priv->changed.contentsSize) > + priv->changed.contentsSize = false; No need for the "if" here, you could just do priv->changed.contentsSize = false; unconditionally.
(In reply to comment #9) > (From update of attachment 125239 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125239&action=review > > r=me > > > Source/WebKit/efl/ChangeLog:9 > > + ewk_tiled_bakcing_store can not detect the conflict between them. > > Typo, ewk_tiled_backing_store. > Thanks. :) > > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1377 > > + if (priv->changed.contentsSize) > > + priv->changed.contentsSize = false; > > No need for the "if" here, you could just do priv->changed.contentsSize = false; unconditionally. You are right.
Created attachment 125246 [details] Patch. Patch updated according to Kling's comment.
Comment on attachment 125246 [details] Patch. Clearing flags on attachment: 125246 Committed r106627: <http://trac.webkit.org/changeset/106627>
All reviewed patches have been landed. Closing bug.