Bug 77583 - [WK2] Use properly quoted string literals
Summary: [WK2] Use properly quoted string literals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-01 16:50 PST by Alexey Proskuryakov
Modified: 2012-02-03 16:31 PST (History)
1 user (show)

See Also:


Attachments
proposed fix (3.65 KB, patch)
2012-02-01 16:59 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff
patch for landing (3.40 KB, patch)
2012-02-03 14:38 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-02-01 16:50:44 PST
Otherwise, "\." matches any character.
Comment 1 Alexey Proskuryakov 2012-02-01 16:59:30 PST
Created attachment 125046 [details]
proposed fix
Comment 2 Darin Adler 2012-02-03 14:20:48 PST
Comment on attachment 125046 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=125046&action=review

r=me, largely based on review by a sandbox expert here at Apple

> Source/WebKit2/ChangeLog:18
> +2012-02-01  Alexey Proskuryakov  <ap@apple.com>
> +
> +        Need a short description and bug URL (OOPS!)
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * WebProcess/com.apple.WebProcess.sb:

Duplicate change log you should remove.
Comment 3 Alexey Proskuryakov 2012-02-03 14:38:28 PST
Created attachment 125417 [details]
patch for landing
Comment 4 WebKit Review Bot 2012-02-03 16:31:41 PST
Comment on attachment 125417 [details]
patch for landing

Clearing flags on attachment: 125417

Committed r106709: <http://trac.webkit.org/changeset/106709>
Comment 5 WebKit Review Bot 2012-02-03 16:31:48 PST
All reviewed patches have been landed.  Closing bug.