Bug 77577 - contentDispositionType misparses the Content-Disposition header in some obscure corner cases
Summary: contentDispositionType misparses the Content-Disposition header in some obscu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-01 14:55 PST by Adam Barth
Modified: 2012-02-01 16:15 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2012-02-01 15:01 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (5.42 KB, patch)
2012-02-01 15:15 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-01 14:55:15 PST 
contentDispositionType misparses the Content-Disposition header in some obscure corner cases
Comment 1 Adam Barth 2012-02-01 15:01:27 PST 
Created attachment 125024 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-01 15:10:01 PST 
Comment on attachment 125024 [details]
Patch

I would like two additional pieces of information in your Changelog.  1.  What happens w/o this patch.  2.  How (if at all) this should affect Safari on Mac/Win.
Comment 3 Adam Barth 2012-02-01 15:15:40 PST 
Created attachment 125029 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-02-01 15:17:29 PST 
Comment on attachment 125029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125029&action=review

> Source/WebCore/ChangeLog:24
> +        Without this patch, these test cases neither trigger a navigation nor a
> +        download in Chromium.  This patch does not appear to cause any visible
> +        change in Safari.  (Safari passes these tests both before and after
> +        this patch.)

You mentioned in person that *if* we saw a change it would be to cause more navigations to be treated as inline rather than downloads.  Is that a correct restatement of our conversation?
Comment 5 Adam Barth 2012-02-01 15:19:07 PST 
> You mentioned in person that *if* we saw a change it would be to cause more navigations to be treated as inline rather than downloads.  Is that a correct restatement of our conversation?

Yes, but testing what actually happens in these cases shows that there isn't any difference in behavior.  These cases appear to already treated as inline, even without this patch.
Comment 6 Eric Seidel (no email) 2012-02-01 15:20:06 PST 
Comment on attachment 125029 [details]
Patch

OK.  Thank you.
Comment 7 Adam Barth 2012-02-01 15:23:33 PST 
Comment on attachment 125029 [details]
Patch

Let's give AP a chance to comment.  (He's in a metting ATM.)
Comment 8 Adam Barth 2012-02-01 15:37:48 PST 
Looks like this function isn't used by anyone except Chromium and Qt.
Comment 9 WebKit Review Bot 2012-02-01 16:15:12 PST 
Comment on attachment 125029 [details]
Patch

Clearing flags on attachment: 125029

Committed r106514: <http://trac.webkit.org/changeset/106514>
Comment 10 WebKit Review Bot 2012-02-01 16:15:17 PST 
All reviewed patches have been landed.  Closing bug.