Bug 77576 - enable Mac EWS for non-contributors
Summary: enable Mac EWS for non-contributors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-01 14:38 PST by Lucas Forschler
Modified: 2012-02-01 15:58 PST (History)
4 users (show)

See Also:

Attachments
Patch to enable EWS for non-contributers (1.00 KB, patch)
2012-02-01 14:38 PST, Lucas Forschler 		abarth: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
add the bug number to the patch (1.85 KB, patch)
2012-02-01 14:43 PST, Lucas Forschler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2012-02-01 14:38:56 PST 
Created attachment 125018 [details]
Patch to enable EWS for non-contributers

Currently EWS on processes patches from contributors.  This will update it to process patches from non-contributers...
Comment 1 Adam Barth 2012-02-01 14:40:37 PST 
Comment on attachment 125018 [details]
Patch to enable EWS for non-contributers

I presume you ran ./Tools/Scripts/test-webkitpy cleanly.
Comment 2 WebKit Review Bot 2012-02-01 14:40:40 PST 
Attachment 125018 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Lucas Forschler 2012-02-01 14:43:56 PST 
Created attachment 125019 [details]
add the bug number to the patch

oops, left out the bug number in change log.
Comment 4 WebKit Review Bot 2012-02-01 15:58:29 PST 
Comment on attachment 125019 [details]
add the bug number to the patch

Clearing flags on attachment: 125019

Committed r106509: <http://trac.webkit.org/changeset/106509>
Comment 5 WebKit Review Bot 2012-02-01 15:58:34 PST 
All reviewed patches have been landed.  Closing bug.