Bug 77548 - Web Inspector: debugger reports wrong sources when paused in inline script on page reload
Summary: Web Inspector: debugger reports wrong sources when paused in inline script on...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-01 05:52 PST by Yury Semikhatsky
Modified: 2012-02-01 09:05 PST (History)
13 users (show)

See Also:


Attachments
Test page (278 bytes, text/html)
2012-02-01 06:02 PST, Yury Semikhatsky
no flags Details
Patch (7.26 KB, patch)
2012-02-01 08:27 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (9.16 KB, patch)
2012-02-01 08:38 PST, Yury Semikhatsky
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-02-01 05:52:52 PST
1. Open attached file.
2. Open inspector.
3. Reload the page.

Result:
When clicking on call frames wrong source line is revealed.
Comment 1 Yury Semikhatsky 2012-02-01 06:02:41 PST
Created attachment 124939 [details]
Test page
Comment 2 Yury Semikhatsky 2012-02-01 08:27:11 PST
Created attachment 124953 [details]
Patch
Comment 3 Yury Semikhatsky 2012-02-01 08:38:54 PST
Created attachment 124956 [details]
Patch
Comment 4 Yury Semikhatsky 2012-02-01 09:03:40 PST
Committed r106468: <http://trac.webkit.org/changeset/106468>
Comment 5 Pavel Podivilov 2012-02-01 09:05:13 PST
Comment on attachment 124956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124956&action=review

Looks good!

> Source/WebCore/bindings/v8/DebuggerScript.js:95
> +        endLine += 1;

nit: Consider adding 1 to lineCount instead to match the comment.