Bug 77545 - Make CSSMappedAttributeDeclaration have CSSMutableStyleDeclaration instead of being one
Summary: Make CSSMappedAttributeDeclaration have CSSMutableStyleDeclaration instead of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77745
  Show dependency treegraph
 
Reported: 2012-02-01 05:14 PST by Antti Koivisto
Modified: 2012-02-03 09:39 PST (History)
4 users (show)

See Also:


Attachments
patch (19.83 KB, patch)
2012-02-01 05:35 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-02-01 05:14:24 PST
This is the easiest path for eliminating the last remaining subclass of CSSMutableStyleDeclaration.
Comment 1 Antti Koivisto 2012-02-01 05:35:33 PST
Created attachment 124935 [details]
patch
Comment 2 Alexis Menard (darktears) 2012-02-01 05:51:30 PST
Comment on attachment 124935 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124935&action=review

> Source/WebCore/dom/CSSMappedAttributeDeclaration.h:73
> +    RefPtr<CSSMutableStyleDeclaration> m_declaration;

Could this be a OwnPtr?
Comment 3 Antti Koivisto 2012-02-01 06:24:24 PST
(In reply to comment #2)
> Could this be a OwnPtr?

No.
Comment 4 Andreas Kling 2012-02-01 08:21:42 PST
Comment on attachment 124935 [details]
patch

r=me
Comment 5 Antti Koivisto 2012-02-01 09:43:38 PST
http://trac.webkit.org/changeset/106471