Bug 77535 – Not correctly recalculating layout for elements within nested SVG elements

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

Created attachment 124911 [details]
Test - Both Images Should Be Identical

I created and attached a test case. Both images should look identical, but for some reason WebKit doesn't seem to recalculate the position of relatively positioned elements whose parent node is a nested <svg> element, whenever that <svg> element is repositioned dynamically. The bug also appears when the browser window is resized since the nested <svg> element is relatively positioned to the browser window. For example:

<svg>
  <svg id="NestedSVG" width="50%">
    <rect x="0" y="0" width="100%" height="100%" />
  </svg>
</svg>

NestedSVG.setAttribute('width', '75%');

[Tim Horton]

While not a regression, this seems pretty broken.

[Radar WebKit Bug Importer]

<rdar://problem/10869870>

[Bear Travis]

The patch for 77903 should fix this as part of updating the viewport/viewbox inner svg transform.
I will double check and add a test case once 77903 has landed.

[Bear Travis]

Created attachment 127421 [details]
Simplified Testcase -- green square

This svg uses a timeout to change the inner svg width to 100% after 2 seconds. You should see a tall green rectangle then a green square.

I'm using the latest Chromium build (19.0.1045.0) for testing so I'm not 100% positive that I'm on the latest build of WebKit. With that being said, the second 'green square' test case is now passing. But my original test case is still not passing. It's much better now, but the <text> element still isn't getting re-positioned.

I think it's important to include different elements in the test case to ensure that they're re-positioned properly as well. I think at least one type of shape (<rect> for example), <text>, and a <use> element should be included. 

As an additional example of why I think it's important to include other elements, the latest version of Firefox has a very similar bug but only with <use> elements.

[Bear Travis]

I see, I hadn't noticed the text. The general resizing working should be due to the patch for 77903. I'll need to take a look at exactly why the text is not repositioning correctly.

[Bear Travis]

Created attachment 128055 [details]
Proposed Patch

After the patch for 77903, there was only a problem with relatively positioned text. Text needs to be marked to reposition itself whenever the viewport size changes, similar to how shapes are being marked in SVGRenderSupport::layoutChildren.

Running the bots, then will mark for review.

[Gustavo Noronha (kov)]

Comment on attachment 128055 [details]
Proposed Patch

Attachment 128055 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11556297

[Bear Travis]

Created attachment 128057 [details]
updated patch

including the new test files

[Bear Travis]

Created attachment 128067 [details]
updated patch

adding a header to fix the gtk build failure

[WebKit Review Bot]

Comment on attachment 128067 [details]
updated patch

Clearing flags on attachment: 128067

Committed r108537: <http://trac.webkit.org/changeset/108537>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.