Bug 77513 - webkit-perf.appspot.com should accept test results without medians
Summary: webkit-perf.appspot.com should accept test results without medians
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77037 77512
  Show dependency tree / graph
 
Reported: 2012-01-31 23:16 PST by Ryosuke Niwa
Modified: 2012-01-31 23:51 PST (History)
2 users (show)

See Also:

Attachments
fixes the bug (2.11 KB, patch)
2012-01-31 23:23 PST, Ryosuke Niwa 		morrita: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-01-31 23:16:57 PST 
Dromaeo tests are missing median values due to some technical issues. webkit-perf should be able to handle such reports.
Comment 1 Ryosuke Niwa 2012-01-31 23:23:40 PST 
Created attachment 124889 [details]
fixes the bug
Comment 2 Hajime Morrita 2012-01-31 23:44:01 PST 
Comment on attachment 124889 [details]
fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=124889&action=review

r=me. Sometime we should have test for this.

> Websites/webkit-perf.appspot.com/report_handler.py:99
> +                TestResult(name=test_name, build=build, value=float(result['avg']), valueMedian=_float_or_none(result, 'median'),

Considering TestResult.value is required field, this change looks reasonable.
Comment 3 Ryosuke Niwa 2012-01-31 23:46:20 PST 
(In reply to comment #2)
> (From update of attachment 124889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124889&action=review
> 
> r=me. Sometime we should have test for this.

Yeah... Unfortunately, App Engine doesn't have any testing framework for python the last time I checked :(

> > Websites/webkit-perf.appspot.com/report_handler.py:99
> > +                TestResult(name=test_name, build=build, value=float(result['avg']), valueMedian=_float_or_none(result, 'median'),
> 
> Considering TestResult.value is required field, this change looks reasonable.

Yes. In fact, _results_are_valid checks the existence of this value.
Comment 4 Ryosuke Niwa 2012-01-31 23:51:32 PST 
Anyway thanks for the review! Landed as http://trac.webkit.org/changeset/106436.