Bug 77505 - Paginated display does not respect page-break-{before,after}
Summary: Paginated display does not respect page-break-{before,after}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-01-31 20:08 PST by mitz
Modified: 2012-02-01 16:02 PST (History)
1 user (show)

See Also:

Attachments
Make RenderView pagination respect page-break properties by default and add API to make it respect column-break properties instead (22.12 KB, patch)
2012-02-01 10:35 PST, mitz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-01-31 20:08:23 PST 
Paginated display does not respect page-break-{before,after}
Comment 1 mitz 2012-01-31 20:09:03 PST 
<rdar://problem/10442663>
Comment 2 mitz 2012-02-01 10:35:55 PST 
Created attachment 124967 [details]
Make RenderView pagination respect page-break properties by default and add API to make it respect column-break properties instead
Comment 3 Darin Adler 2012-02-01 14:18:52 PST 
Comment on attachment 124967 [details]
Make RenderView pagination respect page-break properties by default and add API to make it respect column-break properties instead

View in context: https://bugs.webkit.org/attachment.cgi?id=124967&action=review

> Source/WebCore/rendering/RenderBlock.h:908
> +    virtual ColumnInfo::PaginationUnit paginationUnit();

Make this member function const?

> Source/WebCore/rendering/RenderView.cpp:209
> +    if (m_frameView) {
> +        if (Frame* frame = m_frameView->frame()) {
> +            if (Page* page = frame->page())
> +                return (frame == page->mainFrame() && page->pagination().behavesLikeColumns) ? ColumnInfo::Column : ColumnInfo::Page;
> +        }
> +    }

I think it would be nice to have a helper for the “page if this is the main frame of a page” logic. It’s repeated a few different places and it would be nice if it wasn’t.
Comment 4 mitz 2012-02-01 16:02:58 PST 
Fixed in <http://trac.webkit.org/r106511>.