Bug 77489 - [CG] Failing 2d.shadow.enable.off.2.html on Lion
Summary: [CG] Failing 2d.shadow.enable.off.2.html on Lion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthew Delaney
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-31 16:07 PST by Matthew Delaney
Modified: 2012-01-31 17:21 PST (History)
3 users (show)

See Also:


Attachments
Patch (6.05 KB, patch)
2012-01-31 16:31 PST, Matthew Delaney
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Delaney 2012-01-31 16:07:49 PST
The Philip canvas test named 2d.shadow.enable.off.2.html is currently skipped and otherwise failing on Lion. It tests that shadows aren't drawn under certain conditions as outlined in the canvas spec currently. This bug is for adding that check in.

This part of the spec may change in the future since it's under discussion (see: https://bugs.webkit.org/show_bug.cgi?id=60091) though it's been agreed to leave the spec as-is for now, thus we should conform to it especially since it's a reasonable check to add in.
Comment 1 Matthew Delaney 2012-01-31 16:31:42 PST
Created attachment 124844 [details]
Patch
Comment 2 mitz 2012-01-31 17:00:32 PST
Comment on attachment 124844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124844&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.h:281
> +    bool shouldDrawShadows();

This can be const.
Comment 3 Matthew Delaney 2012-01-31 17:21:37 PST
Committed r106415: <http://trac.webkit.org/changeset/106415>