In the skia platform code, we can eliminate direct dependencies on Ganesh APIs (GrContext in particular) in a few places places by using the recently added SkCanvas::flush method. This will also make some parts of the code clearer and more concise.
Created attachment 125139 [details] Patch
Yay!
Comment on attachment 125139 [details] Patch Attachment 125139 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11386855
Looks like I need a chromium DEPS roll (In reply to comment #3) > (From update of attachment 125139 [details]) > Attachment 125139 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11386855
Created attachment 125151 [details] Patch
Comment on attachment 125151 [details] Patch Looks great! Thanks for the cleanup. r=me
Comment on attachment 125151 [details] Patch Rejecting attachment 125151 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /graphics/chromium/cc/CCLayerTreeHostImpl.h patching file Source/WebCore/platform/graphics/chromium/cc/CCProxy.h patching file Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp patching file Source/WebKit/chromium/DEPS Hunk #1 FAILED at 32. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/DEPS.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Stephen Wh..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11381941
Created attachment 125162 [details] Patch
Comment on attachment 125162 [details] Patch One mo' time! r=me
Comment on attachment 125162 [details] Patch Clearing flags on attachment: 125162 Committed r106601: <http://trac.webkit.org/changeset/106601>
All reviewed patches have been landed. Closing bug.