Bug 77461 - PluginProcess should be able to use remote open and save panels
Summary: PluginProcess should be able to use remote open and save panels
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on:
Reported: 2012-01-31 11:39 PST by Alexey Proskuryakov
Modified: 2012-01-31 11:58 PST (History)
1 user (show)

See Also:

proposed patch (6.27 KB, patch)
2012-01-31 11:45 PST, Alexey Proskuryakov
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-01-31 11:39:39 PST
Sandboxed plug-ins should use remote NSOpenPanel and NSSavePanel.
Comment 1 Alexey Proskuryakov 2012-01-31 11:39:53 PST
Comment 2 Alexey Proskuryakov 2012-01-31 11:45:38 PST
Created attachment 124787 [details]
proposed patch
Comment 3 WebKit Review Bot 2012-01-31 11:48:04 PST
Attachment 124787 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Auto-merging Source/WebCore/WebCore.exp.in
Auto-merging Source/WebKit/mac/ChangeLog
CONFLICT (content): Merge conflict in Source/WebKit/mac/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alexey Proskuryakov 2012-01-31 11:58:27 PST
Committed <http://trac.webkit.org/changeset/106375>.