RESOLVED FIXED Bug 77453
[chromium] Expose windowResizerRectChanged() on WebWidget. 
https://bugs.webkit.org/show_bug.cgi?id=77453
Summary [chromium] Expose windowResizerRectChanged() on WebWidget.
Nico Weber
Reported 2012-01-31 10:41:25 PST
[chromium] Expose windowResizerRectChanged() on WebWidget.
Attachments
Patch (2.87 KB, patch)
2012-01-31 10:41 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.88 KB, patch)
2012-01-31 10:47 PST, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2012-01-31 10:41:55 PST
Created attachment 124771 [details] Patch
WebKit Review Bot
Comment 2 2012-01-31 10:44:13 PST
Attachment 124771 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Fisher (:fishd, Google)
Comment 3 2012-01-31 10:45:22 PST
Comment on attachment 124771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124771&action=review R=me > Source/WebKit/chromium/public/WebWidget.h:188 > + virtual void windowResizerRectChanged() { } nit: please name this didChangeWindowResizerRect() to match naming conventions in the API.
Nico Weber
Comment 4 2012-01-31 10:47:55 PST
Created attachment 124773 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-01-31 15:02:30 PST
Comment on attachment 124773 [details] Patch for landing Clearing flags on attachment: 124773 Committed r106401: <http://trac.webkit.org/changeset/106401>
WebKit Review Bot
Comment 6 2012-01-31 15:02:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.