Vector<T>::operator== shouldn't require T to have operator!=
Created attachment 124765 [details] Patch
Attachment 124765 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r106368: <http://trac.webkit.org/changeset/106368>
Comment on attachment 124765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124765&action=review > Source/JavaScriptCore/ChangeLog:9 > + Change VectorComparer::compare to use !(a == b) instead of a != b since > + it makes more sense for Vector::operator== to use the element's operator==. But now Vector::operator!= requires the element to have operator== ;-)