Formal interfaces for domain agents are already prepared in BackendDispatcher. It's time agents actually implemented them.
Created attachment 124758 [details] Patch
Attachment 124758 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 124761 [details] Patch
Attachment 124761 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 124762 [details] Patch
Attachment 124762 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 124762 [details] Patch Attachment 124762 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11386020
Comment on attachment 124762 [details] Patch Attachment 124762 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11394010
Comment on attachment 124762 [details] Patch Attachment 124762 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11388040
Comment on attachment 124762 [details] Patch Attachment 124762 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11394067
Created attachment 124815 [details] Patch
Comment on attachment 124815 [details] Patch Attachment 124815 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11388128
Comment on attachment 124815 [details] Patch Attachment 124815 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11387144
Comment on attachment 124815 [details] Patch Attachment 124815 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11394117
Created attachment 124828 [details] Patch
Created attachment 124964 [details] Patch
Created attachment 124984 [details] Patch
Comment on attachment 124984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124984&action=review Looks good, but please add virtual to the methods that became virtual. > Source/WebCore/inspector/InspectorCSSAgent.h:80 > + void getMatchedStylesForNode(ErrorString*, int nodeId, const RefPtr<InspectorArray>* forcedPseudoClasses, const bool* includePseudo, const bool* includeInherited, RefPtr<InspectorArray>& matchedCSSRules, RefPtr<InspectorArray>& pseudoIdRules, RefPtr<InspectorArray>& inheritedEntries); We usually keep virtual keywords for overridden virtual methods even though C++ doesn't require this.
Created attachment 125535 [details] Patch
> We usually keep virtual keywords for overridden virtual methods even though C++ doesn't require this. Done.
Comment on attachment 125535 [details] Patch Clearing flags on attachment: 125535 Committed r106777: <http://trac.webkit.org/changeset/106777>
All reviewed patches have been landed. Closing bug.
Qt minimal build failed: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/41992/steps/compile-webkit/logs/stdio I'll land a fix shortly.
(In reply to comment #23) > Qt minimal build failed: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/41992/steps/compile-webkit/logs/stdio > > I'll land a fix shortly. Fixed: http://trac.webkit.org/changeset/106780