Bug 77438 - MediaStream API: Removing the deprecated data message support from PeerConnection
Summary: MediaStream API: Removing the deprecated data message support from PeerConnec...
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency treegraph
 
Reported: 2012-01-31 07:41 PST by Tommy Widenflycht
Modified: 2012-02-10 10:52 PST (History)
3 users (show)

See Also:


Attachments
Patch (15.32 KB, patch)
2012-01-31 07:46 PST, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (15.99 KB, patch)
2012-01-31 08:09 PST, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-01-31 07:41:41 PST
This API will come back in a completely different form later but right now data message support has been removed from the standard.
Comment 1 Tommy Widenflycht 2012-01-31 07:46:39 PST
Created attachment 124731 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-31 07:51:46 PST
Attachment 124731 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Philippe Normand 2012-01-31 07:51:55 PST
Comment on attachment 124731 [details]
Patch

Attachment 124731 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11372337
Comment 4 Tommy Widenflycht 2012-01-31 08:09:31 PST
Created attachment 124735 [details]
Patch
Comment 5 WebKit Review Bot 2012-01-31 08:12:41 PST
Attachment 124735 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tommy Widenflycht 2012-01-31 08:22:44 PST
Style passes without comments locally.
Comment 7 Adam Barth 2012-01-31 15:08:11 PST
(In reply to comment #6)
> Style passes without comments locally.

Yeah, sorry, the bot has some problems with its working copy.
Comment 8 Adam Barth 2012-01-31 15:09:21 PST
Comment on attachment 124735 [details]
Patch

This change looks fine, but we'll need fishd to review because of the change to the public headers.
Comment 9 Adam Barth 2012-01-31 15:09:38 PST
+ fishd for WebKit API review.
Comment 10 Tommy Widenflycht 2012-02-01 02:52:32 PST
Seems that the new hot thing might be deprecated before it was launched. Leaving the old API in place until everyone agrees what the right thing is.
Comment 11 Eric Seidel (no email) 2012-02-10 10:52:45 PST
Comment on attachment 124735 [details]
Patch

Cleared review? from attachment 124735 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).